Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter view should recover when errors happen #2299

Open
TheBestPessimist opened this issue Jun 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@TheBestPessimist
Copy link
Member

commented Jun 10, 2019

Is this a bug or feature request?

BUG

What is the current behavior?

When filtering and an error is thrown, the error is displayed () but the "loading screen" over the data remains forever (as if waiting for the response) (🚫).
The only way to recover from this is to reload the view, which destroys the filter input (which is bad).

0000000145

A second problem is that the loading overlay does not cover the whole window area, only the portion which had the table.

0000000159

Which are the steps to reproduce?

Example to test on: Business Partner window (/window/123), Area Search filter -> add 99999999999999 distance.

What is the expected or desired behavior?

After the error is thrown, the "loading screen" should disappear and the filter view should be shown again, with all the user input preserved, so that the user can fix it and re-search.

The loading overlay (screen) should cover the whole working area (in my second gif see how a portion on the right side is not covered) but not the top navbar.
The z-index for the elements in the navbar (actions menu, notification menu, and "user details" menu, any other?) should be set so that they appear above the loading overlay, and not below it.

@oliviupis oliviupis self-assigned this Jun 10, 2019

@oliviupis oliviupis added the type:bug label Jun 10, 2019

@oliviupis oliviupis referenced this issue Jun 11, 2019

Open

Dev 2299 #2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.