Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master window websocket handling test #2648

Merged
merged 7 commits into from Mar 23, 2020
Merged

Master window websocket handling test #2648

merged 7 commits into from Mar 23, 2020

Conversation

@siemiatj
Copy link
Contributor

siemiatj commented Mar 20, 2020

Related to #2645

@siemiatj siemiatj force-pushed the master-window-tests branch from 03696c7 to e7b9e0b Mar 20, 2020
@siemiatj

This comment has been minimized.

Copy link
Contributor Author

siemiatj commented Mar 20, 2020

Waiting for bump of node version in Jenkins to get a green build

Copy link
Member

TheBestPessimist left a comment

@petrican

This comment has been minimized.

Copy link
Contributor

petrican commented Mar 23, 2020

jenkins build fails even with node 13 https://jenkins.metasfresh.com/job/metasfresh-webui-frontend/job/master-window-tests/6/console

@siemiatj I see you already updated jsdom and set jest-environment-jsdom-sixteen. Not sure what is going on this needs to be investigated a bit. Thanks

@siemiatj siemiatj force-pushed the master-window-tests branch from 0c6b39c to df85fb8 Mar 23, 2020
@siemiatj siemiatj merged commit 978b2be into master Mar 23, 2020
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codebeat no reportable quality changes
Details
continuous-integration/jenkins/branch This commit looks good
Details
@siemiatj siemiatj deleted the master-window-tests branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.