New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Country in Price List not working #2822

Closed
metasnw opened this Issue Oct 25, 2017 · 2 comments

Comments

Projects
None yet
6 participants
@metasnw
Member

metasnw commented Oct 25, 2017

Is this a bug or feature request?

bug

What is the current behavior?

can not use price list with empty country to calculate price

Which are the steps to reproduce?

  1. have price system with two price lists like this one https://w101.metasfresh.com:8443/window/146/2000837
  2. take out country from DE so the field is empty
  3. create a sales order for testkunde in DE
  4. NOK: currency CHF. Expectation: takes DE pricelist because customer address is not switzerland

What is the expected or desired behavior?

Expectation: takes DE pricelist because customer address is not switzerland

@metasnw metasnw added the type:bug label Oct 25, 2017

@cristinamghita cristinamghita self-assigned this Nov 1, 2017

cristinamghita added a commit that referenced this issue Nov 3, 2017

#2822 Should be null, not 0
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Nov 6, 2017

#2822 Add unit test for testing pricing for subscription
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Nov 6, 2017

#2822 Add test for enpty country in price list
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Nov 6, 2017

#2822 Need to use -1 for setting country to null, because otherwise t…
…he test will not catch the case

#2822 Empty Country in Price List not working

teosarca added a commit that referenced this issue Nov 6, 2017

Merge pull request #2921 from metasfresh/gh2822
#2822 Empty Country in Price List not working

@cristinamghita cristinamghita removed their assignment Nov 22, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 7, 2017

Contributor

IT
repeated the testcase above => currency is CHF NOK

Contributor

metas-lc commented Dec 7, 2017

IT
repeated the testcase above => currency is CHF NOK

cristinamghita added a commit that referenced this issue Dec 21, 2017

#2822 Fix method
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Dec 21, 2017

#2822 Remove plain method - not needed
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Dec 21, 2017

#2822 Remove sql string
#2822 Empty Country in Price List not working

cristinamghita added a commit that referenced this issue Dec 21, 2017

#2822 Add unit test
#2822 Empty Country in Price List not working

teosarca added a commit that referenced this issue Dec 21, 2017

Merge pull request #3247 from metasfresh/gh2822_1
#2822 Empty Country in Price List not working

metas-ts added a commit that referenced this issue Jan 5, 2018

update releaseNotes
[#768](metasfresh/metasfresh-webui-api#768)
Picking Tray Clearing: packing HUs: generate shipper's package label
[#3281](#3281)
C_Tax.ValidFrom bug
[#3272](#3272) Provide
Periods for 2018
[#741](metasfresh/metasfresh-webui-api#741)
WebUI window C_Printing_Queue broken
[#769](metasfresh/metasfresh-webui-api#769)
New context variable for isWebUI
[#764](metasfresh/metasfresh-webui-api#764)
Receipt candidates: HU editor: cannot call Transform for a CU
[#3237](#3237) New
Document "Source of Supply"
[#1465](metasfresh/metasfresh-webui-frontend#1465)
frontend: Processes: when calling a process frontend shall provide which
are the selected rows in the left/right view
[#3230](#3230) Pharma:
import prices
[#763](metasfresh/metasfresh-webui-api#763)
Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship
and Invoice action
[#2822](#2822) Empty
Country in Price List not working
[#3238](#3238) Create
Missing M_Cost records on the fly
[#1752](#1752) System
Element overwrite on Window Field
[#3233](#3233) WebUI:
Role permission constraints missing in Subtabs
[#757](metasfresh/metasfresh-webui-api#757)
elasticsearch shall use slf4j instead of log4j
[#752](metasfresh/metasfresh-webui-api#752)
Picking Tray Clearing: picking slot filter no results
[#3227](#3227) Attachment
related perf problem in swing client
[#3155](#3155) Create
special pharma import product table
[#3225](#3225) Error on
unclosing a "manually" created PPOrder
[#3222](#3222) refactor
trx event listeners
[#758](metasfresh/metasfresh-webui-api#758)
Picking Tray Clearing: process to take out an HU and add it to existing
HU
[#760](metasfresh/metasfresh-webui-api#760)
Picking Tray Clearing: process to take out an HU and add it to new HU

@metas-rc metas-rc self-assigned this Jan 10, 2018

@metas-rc

This comment has been minimized.

Show comment
Hide comment
@metas-rc

metas-rc Jan 10, 2018

Member

Results of IT

Tested on webui

  • OK: The pricelist with empty country is correctly taken when the partner's country doesn't have a pricelist of its own.
  • OK: This works both for SO and PO pricelists
  • OK: If the partner is from a cuntry that has a pricelist, that pricelist is correctly taken (both SO and PO)
Member

metas-rc commented Jan 10, 2018

Results of IT

Tested on webui

  • OK: The pricelist with empty country is correctly taken when the partner's country doesn't have a pricelist of its own.
  • OK: This works both for SO and PO pricelists
  • OK: If the partner is from a cuntry that has a pricelist, that pricelist is correctly taken (both SO and PO)

@metas-rc metas-rc closed this Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment