New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop allowconsolidateinvoice from database #2956

Closed
metasnw opened this Issue Nov 11, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@metasnw
Member

metasnw commented Nov 11, 2017

Is this a bug or feature request?

FR

What is the current behavior?

db column is there although its not used anymore as it was replaced with so_invoice_aggregation_id

Which are the steps to reproduce?

check table and column

What is the expected or desired behavior?

  1. migrate existing records to std aggregation
  2. drop column from db
@metasnw

This comment has been minimized.

Show comment
Hide comment
@metasnw

metasnw Nov 11, 2017

Member

convert existing records:

update c_bpartner
set so_invoice_aggregation_id= 1000000
where so_invoice_aggregation_id is null and allowconsolidateinvoice ='Y';

drop column:
alter table c_bpartner drop column allowconsolidateinvoice;

Member

metasnw commented Nov 11, 2017

convert existing records:

update c_bpartner
set so_invoice_aggregation_id= 1000000
where so_invoice_aggregation_id is null and allowconsolidateinvoice ='Y';

drop column:
alter table c_bpartner drop column allowconsolidateinvoice;

metasnw added a commit that referenced this issue Nov 11, 2017

#2956 drop allowconsolidateinvoice from database
#2956 setting default aggregation on partners that have
isconsolidateinvoice = Y, dropping column

@metas-rc metas-rc self-assigned this Nov 16, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

#2956 Drom column AllowConsolidateInvoice
* plus script renaming
#2956

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

#2956 delete allowconsolidateinvoice from tests, from old comments
* + code cleanup ( mostly deleting old comments)
#2956

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-rc added a commit that referenced this issue Nov 27, 2017

metas-ts added a commit that referenced this issue Nov 28, 2017

metas-rc added a commit that referenced this issue Nov 28, 2017

metas-rc added a commit that referenced this issue Nov 28, 2017

metas-ts added a commit that referenced this issue Nov 28, 2017

Merge pull request #2957 from metasfresh/gh2956
#2956 drop allowconsolidateinvoice from database

metas-ts added a commit that referenced this issue Dec 1, 2017

update releasenotes.md
[#2177](#2177) New Window
for Attribute Search in WebUI
[#3117](#3117) Disable
MStorage.add
[#1357](metasfresh/metasfresh-webui-frontend#1357)
Don't use the legacy view attributes API
[#1367](metasfresh/metasfresh-webui-frontend#1367)
view attributes shall be refreshed when the current selected row is
refreshed
[#3041](#3041) Forecast
Window copy Field content from header to lines when creation
[#3040](#3040) Implement
Clone/ Copy for Forecast Window WebUI
[#1360](metasfresh/metasfresh-webui-frontend#1360)
View field editor: override viewEditorRenderMode on row level
[#2868](#2868) Make
BOMValidate process to work correctly in webui
[#2956](#2956) drop
allowconsolidateinvoice from database
[#3073](#3073) Error:
Could not find or load main class ${argLine}
[#3072](#3072)
de_metas_purchasecandidate schema containing some diagnosis views
[#705](metasfresh/metasfresh-webui-api#705)
Backend Logic for new Date Filter Widget
[#3064](#3064) Multiple
PP Order generation for a materialdispo line
[#3088](#3088) Transform
in material receipt left destroyed HU behind
[#3086](#3086) HU planned
after Purchase Order, destroyed after material receipt
[#3089](#3089) Not able
to start report service with ReportServiceMain.launch
[#3042](#3042)
C_Bpartner: new Additional fields
[#3060](#3060)
TypedSqlQuery Bugs because aggregateList method ignores order
[#3054](#3054) purchase
candidates: document references

me-45

metas-ts added a commit that referenced this issue Dec 4, 2017

metas-ts added a commit that referenced this issue Dec 4, 2017

wrap DDL into db_alter_table to avoid fails wrt views using the table
drop allowconsolidateinvoice from database #2956

(cherry picked from commit 6c6a2de)

metas-ts added a commit that referenced this issue Dec 4, 2017

*now really* wrap DDL into db_alter_table to avoid fails wrt views us…
…ing the table

drop allowconsolidateinvoice from database #2956

@metas-lc metas-lc self-assigned this Dec 19, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 19, 2017

Contributor

IT
allowconsolidateinvoice is not in c_bpartner anymore
there is no element for it
order to invoice creation works fine, no errors
OK

Contributor

metas-lc commented Dec 19, 2017

IT
allowconsolidateinvoice is not in c_bpartner anymore
there is no element for it
order to invoice creation works fine, no errors
OK

@metas-lc metas-lc closed this Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment