New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warehouse picking group #3079

Closed
teosarca opened this Issue Nov 24, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@teosarca
Member

teosarca commented Nov 24, 2017

Is this a bug or feature request?

FR
follow-up of #3078

What is the expected or desired behavior?

  • introduce M_Warehouse_PickingGroup
  • a dropdown in warehouse window to set the picking group (not mandatory)
  • shipment schedules: when searching for QtyOnHand consider all warehouses from same picking group as shipment schedule's warehouse
  • shipment schedules: shall use the new material-dispo to fetch the available QtyOnHand (and not de.metas.storage as it is now)
  • nice to have: drop de.metas.storage project if is possible and easy

Note to IT

  • when allocating QtyOnHand to shipment schedules, all warehouses from same picking group as the shipment schedule's warehouse shall be considered
  • full regression on how the QtyOnHand is allocated to shipment schedules => we switched to material-dispo module for fetching available stock

@teosarca teosarca changed the title from Picking warehouse group to Warehouse picking group Nov 24, 2017

@teosarca teosarca self-assigned this Nov 27, 2017

teosarca added a commit that referenced this issue Nov 27, 2017

teosarca added a commit that referenced this issue Nov 28, 2017

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Nov 28, 2017

teosarca added a commit that referenced this issue Nov 28, 2017

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Nov 28, 2017

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 29, 2017

teosarca added a commit that referenced this issue Nov 30, 2017

fixes & impl see below
#3079
* fixes
* refactoring

#3098
* added placeholders for querying by BPartner

#3104
* introduced MaterialMultiQuery.addToPredefinedBuckets(boolean) flag

metas-ts added a commit that referenced this issue Dec 1, 2017

teosarca added a commit that referenced this issue Dec 5, 2017

teosarca added a commit that referenced this issue Dec 5, 2017

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 5, 2017

Member

issue when using batch entry: searching for a product in batch entry causes internal server error:

"No matching group found for StockResult.AddToResultGroupRequest(warehouseId=540008, productId=2000616, storageAttributesKey=, bpartnerId=-2, qty=5) in StockResult(resultGroups=[StockResult.ResultGroup(warehouseId=-1, productId=2000616, storageAttributesKey=-1000, bpartnerId=-1, qty=0), StockResult.ResultGroup(warehouseId=-1, productId=2005599, storageAttributesKey=-1000, bpartnerId=-1, qty=0)])"
path
"/rest/api/window/143/1000017/1/quickInput/1/field/M_Product_ID/typeahead"

Member

metas-dh commented Dec 5, 2017

issue when using batch entry: searching for a product in batch entry causes internal server error:

"No matching group found for StockResult.AddToResultGroupRequest(warehouseId=540008, productId=2000616, storageAttributesKey=, bpartnerId=-2, qty=5) in StockResult(resultGroups=[StockResult.ResultGroup(warehouseId=-1, productId=2000616, storageAttributesKey=-1000, bpartnerId=-1, qty=0), StockResult.ResultGroup(warehouseId=-1, productId=2005599, storageAttributesKey=-1000, bpartnerId=-1, qty=0)])"
path
"/rest/api/window/143/1000017/1/quickInput/1/field/M_Product_ID/typeahead"

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca
Member

teosarca commented Dec 5, 2017

@metas-dh fixed by 91d26b1

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 8, 2017

Member

Results of IT1
tested in mf15

  • Warehouse picking group: dropdown in warehouse window (in Advanced Edit mode): OK
  • Warehouse picking group: to be set in new Warehouse picking group window: OK
Member

metas-dh commented Dec 8, 2017

Results of IT1
tested in mf15

  • Warehouse picking group: dropdown in warehouse window (in Advanced Edit mode): OK
  • Warehouse picking group: to be set in new Warehouse picking group window: OK

@metas-dh metas-dh self-assigned this Dec 8, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 10, 2017

Member

@metas-dh shall work, but just saying, pls make sure the quantity displayed in Order line, batch entry, product lookup is still working as it was before.

Member

teosarca commented Dec 10, 2017

@metas-dh shall work, but just saying, pls make sure the quantity displayed in Order line, batch entry, product lookup is still working as it was before.

metas-ts added a commit that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 11, 2017

Member

continued testing (in mf15)

=> created 2 new warehouses and a warehouse picking group for both

I. QtyOnHand from manufacturing: tested with existing product Convenience Salat:

  • QtyOnHand from manufacturing in the same warehouse: considered correctly in shipment schedule, OK
  • QtyOnHand from manufacturing in another warehouse: not considered in shipment schedule, OK
  • QtyOnHand from manufacturing in another warehouse, but same warehouse picking group: not considered in shipment schedule, NOK

II. QtyOnHand from material receipt: tested with new product Testsalat:

  • QtyOnHand from material receipt in the same warehouse: not considered correctly in shipment schedule, NOK
  • QtyOnHand from material receipt in another warehouse: not considered in shipment schedule, OK
  • QtyOnHand from material receipt in another warehouse, but same warehouse picking group: not considered in shipment schedule, NOK

=> need to check again with a new product since

  • e.g. QtyOnHand from material receipt in the same warehouse was working the 1st time, but not after sev. material receipts, and
  • e.g. the qty displayed when selecting the product in batch entry was correct (see pic), but then not correct in the shipment schedule

2017-12-11 15_53_26-metasfresh

  • m_attributesetinstance_id for the MD_Candidates from sales orders was always 0, but the one for the MD_Candidates from material receipts was always a different one, although no attributes were set: not sure if this has an influence on the QtyOnHand? for the MD_Candidate from manufacturing order, m_attributesetinstance_id was also 0
Member

metas-dh commented Dec 11, 2017

continued testing (in mf15)

=> created 2 new warehouses and a warehouse picking group for both

I. QtyOnHand from manufacturing: tested with existing product Convenience Salat:

  • QtyOnHand from manufacturing in the same warehouse: considered correctly in shipment schedule, OK
  • QtyOnHand from manufacturing in another warehouse: not considered in shipment schedule, OK
  • QtyOnHand from manufacturing in another warehouse, but same warehouse picking group: not considered in shipment schedule, NOK

II. QtyOnHand from material receipt: tested with new product Testsalat:

  • QtyOnHand from material receipt in the same warehouse: not considered correctly in shipment schedule, NOK
  • QtyOnHand from material receipt in another warehouse: not considered in shipment schedule, OK
  • QtyOnHand from material receipt in another warehouse, but same warehouse picking group: not considered in shipment schedule, NOK

=> need to check again with a new product since

  • e.g. QtyOnHand from material receipt in the same warehouse was working the 1st time, but not after sev. material receipts, and
  • e.g. the qty displayed when selecting the product in batch entry was correct (see pic), but then not correct in the shipment schedule

2017-12-11 15_53_26-metasfresh

  • m_attributesetinstance_id for the MD_Candidates from sales orders was always 0, but the one for the MD_Candidates from material receipts was always a different one, although no attributes were set: not sure if this has an influence on the QtyOnHand? for the MD_Candidate from manufacturing order, m_attributesetinstance_id was also 0
@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 12, 2017

Member

Update:

I. QtyOnHand from manufacturing: tested with existing product that wasn't used anywhere before, to make sure the qties from other testing did not get in the way:

  • production of 100kg
  • sales order for 10kg for the next day, same warehouse: shipment schedule QtyOnHand: 90 (=> is the reduction for this shipment schedule already considered?) if so, then it's OK
  • sales order for 10kg for the next day, different warehouse but same warehouse group: shipment schedule QtyOnHand: -10, NOK
  • sales order for 10kg for the same day, different warehouse but same warehouse group: shipment schedule QtyOnHand: -20, NOK

II. QtyOnHand from material receipt: tested again with another new product, where the product category does not have any ASI set:

  • material receipt of 50 Stk
  • sales order for 10 Stk for the next day, same warehouse: shipment schedule QtyOnHand: 40 (=> is the reduction for this shipment schedule already considered?) if so, then it's OK
  • sales order for 10 Stk for the next day, different warehouse but same warehouse group: shipment schedule QtyOnHand: 30, OK
  • sales order for 10 Stk for the same day, same warehouse: shipment schedule QtyOnHand: 40 (=> is the sales order for the earlier date promised considered first, although it was created later?) if so, then it's OK
  • sales order for 10 Stk for the same day, different warehouse: shipment schedule QtyOnHand: -10, OK

=> warehouse group picking works fine for QtyOnHand coming from material receipt, if m_attributesetinstance_id is 0 for all

=> warehouse group picking did not work for QtyOnHand coming from manufacturing

Member

metas-dh commented Dec 12, 2017

Update:

I. QtyOnHand from manufacturing: tested with existing product that wasn't used anywhere before, to make sure the qties from other testing did not get in the way:

  • production of 100kg
  • sales order for 10kg for the next day, same warehouse: shipment schedule QtyOnHand: 90 (=> is the reduction for this shipment schedule already considered?) if so, then it's OK
  • sales order for 10kg for the next day, different warehouse but same warehouse group: shipment schedule QtyOnHand: -10, NOK
  • sales order for 10kg for the same day, different warehouse but same warehouse group: shipment schedule QtyOnHand: -20, NOK

II. QtyOnHand from material receipt: tested again with another new product, where the product category does not have any ASI set:

  • material receipt of 50 Stk
  • sales order for 10 Stk for the next day, same warehouse: shipment schedule QtyOnHand: 40 (=> is the reduction for this shipment schedule already considered?) if so, then it's OK
  • sales order for 10 Stk for the next day, different warehouse but same warehouse group: shipment schedule QtyOnHand: 30, OK
  • sales order for 10 Stk for the same day, same warehouse: shipment schedule QtyOnHand: 40 (=> is the sales order for the earlier date promised considered first, although it was created later?) if so, then it's OK
  • sales order for 10 Stk for the same day, different warehouse: shipment schedule QtyOnHand: -10, OK

=> warehouse group picking works fine for QtyOnHand coming from material receipt, if m_attributesetinstance_id is 0 for all

=> warehouse group picking did not work for QtyOnHand coming from manufacturing

metas-ts added a commit that referenced this issue Dec 19, 2017

minor: add coalesce method with suppliers
so the fallback values need to be computed only if neccesary
Warehouse picking group #3079

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 20, 2017

ProductLookupDescriptor - add dateparameter for available stock
also allow to use the descriptor with and without "available stock exploding"
Warehouse picking group metasfresh/metasfresh#3079

@teosarca teosarca assigned metas-ts and unassigned teosarca Jan 12, 2018

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Feb 19, 2018

Member

=> problem with incorrect QtyOnHand from warehouse picking group in shipment schedules will be solved in different task, see above. closing this one.

Member

metas-dh commented Feb 19, 2018

=> problem with incorrect QtyOnHand from warehouse picking group in shipment schedules will be solved in different task, see above. closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment