New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HU planned after Purchase Order, destroyed after material receipt #3086

Closed
metas-mk opened this Issue Nov 27, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@metas-mk
Member

metas-mk commented Nov 27, 2017

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, after creating a Purchase Order, there are Handling Units created and set into status "planned". After doing the Material Receipt these HU are "destroyed".

Which are the steps to reproduce?

Open, try and see.

What is the expected or desired behavior?

The HU shall not be destoyed but used for material receipt. If not used then at least delete the unused HU.

Last HU before purchase order:
image

Last HU after purchase order:
image

Last HU after Material Receipt (info: Destroyed HU are not shown anymore):
image

@metas-mk

This comment has been minimized.

Show comment
Hide comment
@metas-mk

metas-mk Nov 27, 2017

Member

Talked w/ @teosarca Get rid of pre-generated HU after Purchase Order/ material Receipt Candidates

Member

metas-mk commented Nov 27, 2017

Talked w/ @teosarca Get rid of pre-generated HU after Purchase Order/ material Receipt Candidates

@teosarca teosarca self-assigned this Nov 27, 2017

teosarca added a commit that referenced this issue Nov 27, 2017

drop FK for C_Queue_Block.C_Queue_PackageProcessor_ID
reason: prevents us from deleting  C_Queue_PackageProcessor(s).
In some cases deleting all those workpackages before deleting the
processor is not fesible.

#3086

teosarca added a commit that referenced this issue Nov 27, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 27, 2017

Member

update: Planning HUs are no longer generated when the receipt candidate is created.
More, i've also dropped the M_ReceiptSchedule.IsHUPrepared column because it no longer makes sense.

Member

teosarca commented Nov 27, 2017

update: Planning HUs are no longer generated when the receipt candidate is created.
More, i've also dropped the M_ReceiptSchedule.IsHUPrepared column because it no longer makes sense.

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Nov 27, 2017

Member

note to IT:

  • regression, on swing too
Member

teosarca commented Nov 27, 2017

note to IT:

  • regression, on swing too

metas-ts added a commit that referenced this issue Dec 1, 2017

update releasenotes.md
[#2177](#2177) New Window
for Attribute Search in WebUI
[#3117](#3117) Disable
MStorage.add
[#1357](metasfresh/metasfresh-webui-frontend#1357)
Don't use the legacy view attributes API
[#1367](metasfresh/metasfresh-webui-frontend#1367)
view attributes shall be refreshed when the current selected row is
refreshed
[#3041](#3041) Forecast
Window copy Field content from header to lines when creation
[#3040](#3040) Implement
Clone/ Copy for Forecast Window WebUI
[#1360](metasfresh/metasfresh-webui-frontend#1360)
View field editor: override viewEditorRenderMode on row level
[#2868](#2868) Make
BOMValidate process to work correctly in webui
[#2956](#2956) drop
allowconsolidateinvoice from database
[#3073](#3073) Error:
Could not find or load main class ${argLine}
[#3072](#3072)
de_metas_purchasecandidate schema containing some diagnosis views
[#705](metasfresh/metasfresh-webui-api#705)
Backend Logic for new Date Filter Widget
[#3064](#3064) Multiple
PP Order generation for a materialdispo line
[#3088](#3088) Transform
in material receipt left destroyed HU behind
[#3086](#3086) HU planned
after Purchase Order, destroyed after material receipt
[#3089](#3089) Not able
to start report service with ReportServiceMain.launch
[#3042](#3042)
C_Bpartner: new Additional fields
[#3060](#3060)
TypedSqlQuery Bugs because aggregateList method ignores order
[#3054](#3054) purchase
candidates: document references

me-45

teosarca added a commit that referenced this issue Dec 4, 2017

hotfixing failing migration script
ERROR:  cannot drop table m_receiptschedule column ishuprepared because
other objects depend on it

#3086

metas-ts added a commit that referenced this issue Dec 4, 2017

hotfixing failing migration script
ERROR:  cannot drop table m_receiptschedule column ishuprepared because
other objects depend on it

#3086
(cherry picked from commit a4773ce)
@metas-ts

This comment has been minimized.

Show comment
Hide comment
@metas-ts

metas-ts Dec 4, 2017

Member

cherry-picked to release

Member

metas-ts commented Dec 4, 2017

cherry-picked to release

@metas-dh metas-dh self-assigned this Dec 6, 2017

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 7, 2017

Member

Results of IT1
tested in mf15

WebUI:

  1. Purchase Order is completed and Material Receipt Candidates are created: no Planning HUs: OK
  2. HU Editor in Material Receipt Candidates is opened, to create material receipt: Planning HUs: OK
  3. Material Receipt created: Planning HUs become Active: OK
  4. Transform Planning HUs Use "TU to new TUs" to take TUs out off the LU: LU is Destroyed, TUs remain Planning: OK
  5. Material Receipt created for 1 TU, close the Editor: 1 TU is now Active, the other is Destroyed: OK

question:
the destroyed LU from step 4. was shown in HU Editor after the Transform, but not the Planning TUs; also the destroyed TU from step 5 was shown in HU Editor: they disappeared after clearing the filter params (had filtered for my product first), is that bc of caching?

after 4.:
2017-12-07 08_50_45-metasfresh

after 5:
2017-12-07 08_57_49-metasfresh

after clearing filter:
2017-12-07 09_18_20-metasfresh

ToDo: Swing testing & regression

Member

metas-dh commented Dec 7, 2017

Results of IT1
tested in mf15

WebUI:

  1. Purchase Order is completed and Material Receipt Candidates are created: no Planning HUs: OK
  2. HU Editor in Material Receipt Candidates is opened, to create material receipt: Planning HUs: OK
  3. Material Receipt created: Planning HUs become Active: OK
  4. Transform Planning HUs Use "TU to new TUs" to take TUs out off the LU: LU is Destroyed, TUs remain Planning: OK
  5. Material Receipt created for 1 TU, close the Editor: 1 TU is now Active, the other is Destroyed: OK

question:
the destroyed LU from step 4. was shown in HU Editor after the Transform, but not the Planning TUs; also the destroyed TU from step 5 was shown in HU Editor: they disappeared after clearing the filter params (had filtered for my product first), is that bc of caching?

after 4.:
2017-12-07 08_50_45-metasfresh

after 5:
2017-12-07 08_57_49-metasfresh

after clearing filter:
2017-12-07 09_18_20-metasfresh

ToDo: Swing testing & regression

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 7, 2017

Member

the destroyed LU from step 4. was shown in HU Editor after the Transform, but not the Planning TUs; also
the destroyed TU from step 5 was shown in HU Editor: they disappeared after clearing the filter params
(had filtered for my product first), is that bc of caching?

nop, it's because of #3088.
Everything related to transform and destroyed HUs left behind is because of that task.

Member

teosarca commented Dec 7, 2017

the destroyed LU from step 4. was shown in HU Editor after the Transform, but not the Planning TUs; also
the destroyed TU from step 5 was shown in HU Editor: they disappeared after clearing the filter params
(had filtered for my product first), is that bc of caching?

nop, it's because of #3088.
Everything related to transform and destroyed HUs left behind is because of that task.

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 7, 2017

Member

thx for the info!

Swing:

  1. Purchase Order is completed and Material Receipt Candidates are created: no Planning HUs: OK
  2. HU Editor in Material Receipt Candidates is opened, to create material receipt: Planning HUs: OK
  3. Material Receipt created: Planning HUs become Active: OK
  4. Transform Planning HUs Use "TU to new TUs" to take TUs out off the LU: LU is Destroyed, TUs remain Planning: OK
  5. Material Receipt created for 1 TU, close the Editor: 1 TU is now Active, the other is Destroyed: OK

difference:
=> when you open the HU Editor in Material Receipt Candidates, then you get Planning HUs, both in Swing and WebUI: OK
but:

  • in Swing, when you close the Editor without doing anything and reopen it (with the same Gebindekonfig), you get the same HUs (same values) to receive / work with
  • in WebUI, the Planning HUs remain after closing the Editor (you can still find them in Handling Unit Editor window), but when you open the Editor in Material Receipt Candidates again, you get new Planing HUs (different HU values), and the old ones are destroyed
    => why this difference?
Member

metas-dh commented Dec 7, 2017

thx for the info!

Swing:

  1. Purchase Order is completed and Material Receipt Candidates are created: no Planning HUs: OK
  2. HU Editor in Material Receipt Candidates is opened, to create material receipt: Planning HUs: OK
  3. Material Receipt created: Planning HUs become Active: OK
  4. Transform Planning HUs Use "TU to new TUs" to take TUs out off the LU: LU is Destroyed, TUs remain Planning: OK
  5. Material Receipt created for 1 TU, close the Editor: 1 TU is now Active, the other is Destroyed: OK

difference:
=> when you open the HU Editor in Material Receipt Candidates, then you get Planning HUs, both in Swing and WebUI: OK
but:

  • in Swing, when you close the Editor without doing anything and reopen it (with the same Gebindekonfig), you get the same HUs (same values) to receive / work with
  • in WebUI, the Planning HUs remain after closing the Editor (you can still find them in Handling Unit Editor window), but when you open the Editor in Material Receipt Candidates again, you get new Planing HUs (different HU values), and the old ones are destroyed
    => why this difference?
@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 7, 2017

Member

@metas-dh agreed with @metas-mk to create a follow-up for that issue: metasfresh/metasfresh-webui-api#729

Besides that, i think everything is fulfilled, right?

Member

teosarca commented Dec 7, 2017

@metas-dh agreed with @metas-mk to create a follow-up for that issue: metasfresh/metasfresh-webui-api#729

Besides that, i think everything is fulfilled, right?

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Dec 8, 2017

Member

@teosarca thx for the info, closing this one.

Member

metas-dh commented Dec 8, 2017

@teosarca thx for the info, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment