New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always keep Terms & Conditions equal per Compensation Group #3150

Closed
metas-mk opened this Issue Dec 6, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@metas-mk
Member

metas-mk commented Dec 6, 2017

Is this a bug or feature request?

Feature Request

What is the current behavior?

Currently, the user can define different Terms and conditions per group.

Which are the steps to reproduce?

  • create an orderline and additional group line
  • change the terms and conditions per line individually.

What is the expected or desired behavior?

The Terms and conditions of a compensation group shall always be equal in all lines of the group.

  • if the user adjusts the terms & conditions of a line that belongs to a group, then all group lines are updates/ set to the same terms and conditions id
  • id the user creates a new line, sets the terms and conditions and then creates a group with another product, then that additional line shall initially have the terms & conditions of the first line.

image

teosarca added a commit that referenced this issue Dec 7, 2017

teosarca added a commit that referenced this issue Dec 7, 2017

teosarca added a commit that referenced this issue Dec 7, 2017

teosarca added a commit that referenced this issue Dec 7, 2017

@metasnw

This comment has been minimized.

Show comment
Hide comment
@metasnw

metasnw Dec 8, 2017

Member

is waiting for #3149 to be working

Member

metasnw commented Dec 8, 2017

is waiting for #3149 to be working

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 8, 2017

Member

shall be available on next build/rollout.

Member

teosarca commented Dec 8, 2017

shall be available on next build/rollout.

teosarca added a commit that referenced this issue Dec 10, 2017

@teosarca

This comment has been minimized.

Show comment
Hide comment
@teosarca

teosarca Dec 10, 2017

Member

Hotfixed following case:

  • have a discount schema with a discount defined for your group compensation product
  • have an order with a regular order line, terms & conditions not set
  • select the line and from menu create a compensation group (on w101, use Discount 10% product which already has a discount schema configured on bpartner nw_test01) => Compensation Percentage is set from discount schema => OK
  • on first line, go and change the term&conditions from "nothing" to "abo".
    => both lines now have the "abo" terms and conditions => OK
    => on second line (i.e. the discount line) remark that there is a difference between PriceEntered and PriceActual => right click on that line and go to Advanced edit. In advanced edit, remark that the Discount (i am not talking about group compensation percent!) is set (to 5% in my case) => NOK, when a line is a group compensation line the Discount shall ALWAYS be ZERO.
Member

teosarca commented Dec 10, 2017

Hotfixed following case:

  • have a discount schema with a discount defined for your group compensation product
  • have an order with a regular order line, terms & conditions not set
  • select the line and from menu create a compensation group (on w101, use Discount 10% product which already has a discount schema configured on bpartner nw_test01) => Compensation Percentage is set from discount schema => OK
  • on first line, go and change the term&conditions from "nothing" to "abo".
    => both lines now have the "abo" terms and conditions => OK
    => on second line (i.e. the discount line) remark that there is a difference between PriceEntered and PriceActual => right click on that line and go to Advanced edit. In advanced edit, remark that the Discount (i am not talking about group compensation percent!) is set (to 5% in my case) => NOK, when a line is a group compensation line the Discount shall ALWAYS be ZERO.

metas-ts added a commit that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted

@metasnw metasnw self-assigned this Dec 11, 2017

@metasnw

This comment has been minimized.

Show comment
Hide comment
@metasnw

metasnw Dec 11, 2017

Member

testing together with #3149

Member

metasnw commented Dec 11, 2017

testing together with #3149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment