New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins misinterprets positive downstream build result #3183

Closed
metas-ts opened this Issue Dec 11, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@metas-ts
Member

metas-ts commented Dec 11, 2017

Is this a bug or feature request?

Bug

What is the current behavior?

Builds fail with the following message:
ERROR: An external job that was invoked by zapier failed; message=OK;
so the "OK" comint from the external job is somehow misinterpreted

@metas-ts metas-ts added the type:bug label Dec 11, 2017

@metas-ts metas-ts self-assigned this Dec 11, 2017

metas-ts added a commit that referenced this issue Dec 11, 2017

Attempt to solve the problem:
* use == instead of !=
* use .trim() on the result string

also refactor the method and handle the case that  null return is
returned

Jenkins misinterprets positive downstream build result
#3183

metas-ts added a commit that referenced this issue Dec 11, 2017

create inlining creation of json payload cause it needs too many params
..and right now i can't reafactor further :(

Jenkins misinterprets positive downstream build result #3183

@metas-ts metas-ts removed their assignment Dec 11, 2017

@metas-ts

This comment has been minimized.

Show comment
Hide comment
@metas-ts

metas-ts Dec 11, 2017

Member

Note: nothing to do for IT

Member

metas-ts commented Dec 11, 2017

Note: nothing to do for IT

@metas-ts metas-ts closed this Dec 11, 2017

@metas-ts metas-ts reopened this Dec 11, 2017

metas-ts added a commit that referenced this issue Dec 11, 2017

update ReleaseNotes.md
[#3183](#3183) Jenkins
misinterprets positive downstream build result

@metas-ts metas-ts closed this Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment