New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor trx event listeners #3222

Closed
metas-ts opened this Issue Dec 18, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@metas-ts
Member

metas-ts commented Dec 18, 2017

Is this a bug or feature request?

FR

What is the current behavior?

  • currently you have one ITrxListner interface with a number of methods.
  • the problem with that is that if you register another listener within a listener's method (for the same transaction), the frameworks can't dedice whether that's OK or not
    • OK-example: register a listener for after-rollback from within a listener's before-commit
    • NOK: register things other way round

What is the expected or desired behavior?

With the new API, we register things and explicitly specify what code is to be executed on which event.

@metas-ts metas-ts self-assigned this Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

add the new API and chang all the code to use it
also remove the old ITrxListener etc

refactor trx event listeners #3222

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

additional minor (formatting) changes
refactor trx event listeners #3222

metas-ts added a commit that referenced this issue Dec 18, 2017

change the API to make it harder to screw up
thx @teosarca for feedback
refactor trx event listeners #3222

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 18, 2017

change the API to make it harder to screw up
thx @teosarca for feedback
refactor trx event listeners metasfresh/metasfresh#3222

metas-ts added a commit that referenced this issue Dec 18, 2017

Merge pull request #3223 from metasfresh/gh3222-app
refactor trx event listeners #3222

metas-ts added a commit that referenced this issue Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

solve furether unit tests failures
compare with the old code and restore/make explicit each "run once"/"run always" setting
refactor trx event listeners #3222

metas-ts added a commit that referenced this issue Dec 18, 2017

compare with the old code and restore/"make explicit" each "run once"…
…/"run always" setting

refactor trx event listeners #3222

metas-ts added a commit that referenced this issue Dec 18, 2017

compare with the old code and restore/"make explicit" each "run once"…
…/"run always" setting

refactor trx event listeners #3222

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

metas-ts added a commit that referenced this issue Dec 18, 2017

solve another bunch of problems by registering only one listener weekly
..which is in PO..which is turn is the only use that was registered weekly before

refactor trx event listeners #3222

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Dec 21, 2017

@metas-ts metas-ts removed their assignment Jan 5, 2018

metas-ts added a commit that referenced this issue Jan 5, 2018

update releaseNotes
[#768](metasfresh/metasfresh-webui-api#768)
Picking Tray Clearing: packing HUs: generate shipper's package label
[#3281](#3281)
C_Tax.ValidFrom bug
[#3272](#3272) Provide
Periods for 2018
[#741](metasfresh/metasfresh-webui-api#741)
WebUI window C_Printing_Queue broken
[#769](metasfresh/metasfresh-webui-api#769)
New context variable for isWebUI
[#764](metasfresh/metasfresh-webui-api#764)
Receipt candidates: HU editor: cannot call Transform for a CU
[#3237](#3237) New
Document "Source of Supply"
[#1465](metasfresh/metasfresh-webui-frontend#1465)
frontend: Processes: when calling a process frontend shall provide which
are the selected rows in the left/right view
[#3230](#3230) Pharma:
import prices
[#763](metasfresh/metasfresh-webui-api#763)
Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship
and Invoice action
[#2822](#2822) Empty
Country in Price List not working
[#3238](#3238) Create
Missing M_Cost records on the fly
[#1752](#1752) System
Element overwrite on Window Field
[#3233](#3233) WebUI:
Role permission constraints missing in Subtabs
[#757](metasfresh/metasfresh-webui-api#757)
elasticsearch shall use slf4j instead of log4j
[#752](metasfresh/metasfresh-webui-api#752)
Picking Tray Clearing: picking slot filter no results
[#3227](#3227) Attachment
related perf problem in swing client
[#3155](#3155) Create
special pharma import product table
[#3225](#3225) Error on
unclosing a "manually" created PPOrder
[#3222](#3222) refactor
trx event listeners
[#758](metasfresh/metasfresh-webui-api#758)
Picking Tray Clearing: process to take out an HU and add it to existing
HU
[#760](metasfresh/metasfresh-webui-api#760)
Picking Tray Clearing: process to take out an HU and add it to new HU

@metas-rc metas-rc self-assigned this Jan 12, 2018

@metas-rc

This comment has been minimized.

Show comment
Hide comment
@metas-rc

metas-rc Jan 12, 2018

Member

Nothing to IT. Moving to done.

Member

metas-rc commented Jan 12, 2018

Nothing to IT. Moving to done.

@metas-rc metas-rc closed this Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment