New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Role permission constraints missing in Subtabs #3233

Closed
metas-mk opened this Issue Dec 19, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@metas-mk
Member

metas-mk commented Dec 19, 2017

Is this a bug or feature request?

Bug

What is the current behavior?

Currently, the Role Permission constraints are missing in WebUI. Its possible to create permission entries for the same element multiple times. Is handled in Swing.

Which are the steps to reproduce?

Open, try and see.

What is the expected or desired behavior?

Shall only be able to set a permission once per Role and org/ client combination.

@metas-mk

This comment has been minimized.

Show comment
Hide comment
@metas-mk

metas-mk Dec 19, 2017

Member

wrong comment

Member

metas-mk commented Dec 19, 2017

wrong comment

metas-ts added a commit that referenced this issue Jan 5, 2018

update releaseNotes
[#768](metasfresh/metasfresh-webui-api#768)
Picking Tray Clearing: packing HUs: generate shipper's package label
[#3281](#3281)
C_Tax.ValidFrom bug
[#3272](#3272) Provide
Periods for 2018
[#741](metasfresh/metasfresh-webui-api#741)
WebUI window C_Printing_Queue broken
[#769](metasfresh/metasfresh-webui-api#769)
New context variable for isWebUI
[#764](metasfresh/metasfresh-webui-api#764)
Receipt candidates: HU editor: cannot call Transform for a CU
[#3237](#3237) New
Document "Source of Supply"
[#1465](metasfresh/metasfresh-webui-frontend#1465)
frontend: Processes: when calling a process frontend shall provide which
are the selected rows in the left/right view
[#3230](#3230) Pharma:
import prices
[#763](metasfresh/metasfresh-webui-api#763)
Picking Tray Clearing: packing HUs: Add to Transportation Order, Ship
and Invoice action
[#2822](#2822) Empty
Country in Price List not working
[#3238](#3238) Create
Missing M_Cost records on the fly
[#1752](#1752) System
Element overwrite on Window Field
[#3233](#3233) WebUI:
Role permission constraints missing in Subtabs
[#757](metasfresh/metasfresh-webui-api#757)
elasticsearch shall use slf4j instead of log4j
[#752](metasfresh/metasfresh-webui-api#752)
Picking Tray Clearing: picking slot filter no results
[#3227](#3227) Attachment
related perf problem in swing client
[#3155](#3155) Create
special pharma import product table
[#3225](#3225) Error on
unclosing a "manually" created PPOrder
[#3222](#3222) refactor
trx event listeners
[#758](metasfresh/metasfresh-webui-api#758)
Picking Tray Clearing: process to take out an HU and add it to existing
HU
[#760](metasfresh/metasfresh-webui-api#760)
Picking Tray Clearing: process to take out an HU and add it to new HU

@metas-dh metas-dh self-assigned this Jan 10, 2018

@metas-dh

This comment has been minimized.

Show comment
Hide comment
@metas-dh

metas-dh Jan 10, 2018

Member

Results of IT1
tested in customer db

  • only 1 permission per Role and org/ client combination is possible: OK
Member

metas-dh commented Jan 10, 2018

Results of IT1
tested in customer db

  • only 1 permission per Role and org/ client combination is possible: OK

@metas-dh metas-dh closed this Jan 10, 2018

@metasnw

This comment has been minimized.

Show comment
Hide comment
@metasnw

metasnw Jan 30, 2018

Member

@metas-dh @teosarca
the script is failing on live instances where duplicates are already existing which is particular difficult to fix when using docker. For somebody who is not a total expert its nearly impossible to fix.

Therefore I recommend to keep regression in mind on this kind of issues in both development AND testing.

here is the actual problem:

      psql:/opt/metasfresh/dist/sql/10-de.metas.adempiere/5480915_sys_gh3233_RoleAccess_indexes.sql:9: ERROR:  could not create unique index "ad_window_access_uq"
        DETAIL:  Key (ad_role_id, ad_window_id)=(540026, 540165) is duplicated.

I documented the workaround here:
https://github.com/metasfresh/metasfresh-documentation/blob/gh-pages/_support_collection/en/manually_apply_migration_script.md

Member

metasnw commented Jan 30, 2018

@metas-dh @teosarca
the script is failing on live instances where duplicates are already existing which is particular difficult to fix when using docker. For somebody who is not a total expert its nearly impossible to fix.

Therefore I recommend to keep regression in mind on this kind of issues in both development AND testing.

here is the actual problem:

      psql:/opt/metasfresh/dist/sql/10-de.metas.adempiere/5480915_sys_gh3233_RoleAccess_indexes.sql:9: ERROR:  could not create unique index "ad_window_access_uq"
        DETAIL:  Key (ad_role_id, ad_window_id)=(540026, 540165) is duplicated.

I documented the workaround here:
https://github.com/metasfresh/metasfresh-documentation/blob/gh-pages/_support_collection/en/manually_apply_migration_script.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment