New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link and templates for email notification #3879

Closed
metas-dh opened this Issue Apr 18, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@metas-dh
Member

metas-dh commented Apr 18, 2018

Is this a bug or feature request?

FR

What is the current behavior?

Follow-up of #3708
Atm, the emails sent don't include a link and only a short info, like e.g. "Approve credit limit" for BPartner - Credit Limit Approval, so the recipient of the email does not know which bpartner's credit limit shall be approved.

Which are the steps to reproduce?

Try and see.

What is the expected or desired behavior?

  • add a link in the resp. email, so the recipient can just use it to open the resp. data in WebUI
  • add templates for the emails so the resp. information can be improved / customized
@teosarca

This comment has been minimized.

Member

teosarca commented Apr 20, 2018

fixed in gh3708 branch. To be tested there.

teosarca added a commit that referenced this issue Apr 20, 2018

teosarca added a commit that referenced this issue Apr 20, 2018

@metas-dh

This comment has been minimized.

Member

metas-dh commented Apr 20, 2018

Results of IT1
tested in dev30

  • bpartner no. is included in email for credit limit approval: OK
  • bpartner no. should include link to open the resp. data in WebUI: no link as included, NOK
@teosarca

This comment has been minimized.

Member

teosarca commented May 4, 2018

@metas-dh it's a config issue.
Sysconfig webui.frontend.url shall be set with the frontend's URL.
On w101 i've set it to https://w101.metasfresh.com:8443 so it shall work.

@teosarca

This comment has been minimized.

Member

teosarca commented May 16, 2018

btw, this one can be tested on master branch

metas-ts added a commit that referenced this issue May 22, 2018

update ReleaseNotes.md
[#4073](#4073) Virtual Tabs implementation
[#4018](#4018) QtyCU not respected in Quarantine DD_Orderline
[#4063](#4063) Enhanced Pricing: Discount Break is falsely invalidated
[#4032](#4032) Show Pricing Conditions of Business Partner
[#4001](#4001) Calculate Purchase price with yearly Bonus
[#3999](#3999) New contract Type: Yearly Bonus from vendors
[#4070](#4070) WebUI Windows for new contract Type "Yearly
[#1789](metasfresh/metasfresh-webui-frontend#1789) user notifications: handle view target type
[#4071](#4071) exception handling: make them more translatable
[#4047](#4047) CleverReach get paginated receivers list
[#18](metasfresh/metasfresh-dist#18) create docker image automatically via jenkins
[#93](metasfresh/metasfresh-dist-orgs#92) Postal Lookup for Switzerland CH
[#4052](#4052) NPE when deleting inoutline with empty product
[#4062](#4062) Pricing conditions modal: allow changing pricing type, edit pricing system etc
[#4056](#4056) webui: pimp Partner Pharma - Purchase schedule tab
[#4030](#4030) create webui windows for marketing and cleverreach settings
[#1790](metasfresh/metasfresh-webui-frontend#1790) view: refresh after removing a static filter
[#3879](#3879) Add link and templates for email notification
[#4002](#4002) Purchase Order Aggregation
[#3792](#3729) Setting a different invoice bpartner causes error

@metas-lc metas-lc self-assigned this Jun 21, 2018

@metas-lc

This comment has been minimized.

Contributor

metas-lc commented Jun 27, 2018

IT
configs:

  1. set email from to client: IsSmtpAuthorization='Y' , RequestEMail, RequestUser, RequestUserPW, SMTPHost
  2. set org.adempiere.user.api.IUserBL.DebugMailTo on your email
  3. go to Sysconfig webui.frontend.url -> value shall be set with the frontend's URL
  4. my profile window, IT user (the one i'm logged in with) -> set your email
  5. go to notifications tab, set group: BPartner - Credit Limit Approval, type: EMail+Notice
  6. set org.compiere.model.MRequest.EnableNotifications on Y
  7. go to bpatrner, create new credit limit
  8. select the line of your credit limit, go to actions: credit limit request approval
  9. set your user, start
    => notification: Please approve credit limit for 1000001 (if you select it you get to that window)
    => email: Please approve credit limit for 1000001 <[frontend's url]/window/123/2156427>
    OK

@metas-lc metas-lc closed this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment