Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes/Cabling vertical #4396

Closed
teosarca opened this issue Jul 20, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@teosarca
Copy link
Member

commented Jul 20, 2018

Is this a bug or feature request?

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

How to configure

Cable length attribute

IMPORTANT: please use the CableLength as value.
It is hardcoded in the sales order batch entry.

image

Define the BOM

Remark:

  • BOM Type shall be "Make to Order"
  • on cable product we use the CableLength external attribute.

image

Configure the attribute set for our BOM

image
image

Configure the product prices

Remark:

  • all components shall be in the price list
  • the BOM product shall be in the price list (because of tax category) but it's prices shall be ZERO.

image

Enable the cable/pipes profile

By enabling the de.metas.vertical.cables spring profile following changes will be applied:

  • cables/pipes specific quick/batch entry will be used in sales order line.

The profile shall be enabled for metasfresh-webui-api service, e.g. add following to your application.properties

spring.profiles.active=de.metas.vertical.cables

Pricing conditions based on CableLength attribute

HINT: check product price's Price Limit. If it's set it will be enforced no matter of what discount you are setting in pricing conditions.

image

@teosarca teosarca self-assigned this Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 20, 2018

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Jul 20, 2018

teosarca added a commit that referenced this issue Jul 23, 2018

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Jul 23, 2018

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Jul 23, 2018

teosarca added a commit that referenced this issue Jul 24, 2018

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Jul 24, 2018

teosarca added a commit that referenced this issue Jul 24, 2018

teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Jul 24, 2018

teosarca added a commit that referenced this issue Jul 24, 2018

metas-ts added a commit that referenced this issue Jul 25, 2018

Solve unit test issues
Pipes/Cabling vertical #4396

metas-ts added a commit that referenced this issue Jul 25, 2018

Solve unit test issues
Pipes/Cabling vertical #4396

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 25, 2018

teosarca added a commit that referenced this issue Jul 27, 2018

@metasnw

This comment has been minimized.

metas-ts added a commit that referenced this issue Jul 30, 2018

Update ReleaseNotes.md
[#4092](#4092) sync mail address between contactperson and linked user
[#4153](#4216) Follow up : #4153 Serial Letter Feature
[#4396](#4396) Pipes/Cabling vertical
[#4403](#4403) Process to void order and revert flatrate terms, shipment schedule, invoice candidates
[#4413](#4413) ShipmentScheduleHandler.retrieveModelsWithMissingCandidates() shall return an iterator
[#4416](#4416) Split Product Nutrition/ Allergene in 2 Tabs
[#4417](#4417) New Textfield for Product Ingredients without BOM
[#1629](#1629) Invoice data goes missing in payment after save
[#4405](#4405) Action Sales Order from Quotation wrong Prices
[#4412](#4412) async-processors shall only run on app
[#4415](#4415) JSON Fehler "Der Kurier"
[#1889](metasfresh/metasfresh-webui-frontend#1889) Order line batch entry not working for current experimental cables/pipes batch entry

metas-ts added a commit that referenced this issue Jul 30, 2018

ä4396-app - Avoid NPE
Pipes/Cabling vertical #4396

metas-ts added a commit that referenced this issue Jul 30, 2018

ä4396-app - Avoid NPE
Pipes/Cabling vertical #4396

(cherry picked from commit ae30029)
@metas-ts

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

cherrypicked ae30029 to release

@metasnw

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

IT

  • display of label: OK
  • adding new line: OK
  • price calculation: OK
  • discount calculation after increasing qty : OK
  • discount calculation after decreasing qty : NOK
    case:
    • have a discount schema with break = 10 and discount = 50%
    • add a order line
    • increase attribute meter higher than 10
    • OK: discount is correctly set to 50%
    • decrease attribute meter to lower than 10
    • NOK: discount is remains at 50%. Expectation: 0 %

@metasnw metasnw assigned metasnw and unassigned teosarca Jul 30, 2018

metas-ts added a commit that referenced this issue Jul 30, 2018

#4396-app - Avoid another NPE
Pipes/Cabling vertical #4396

metas-ts added a commit that referenced this issue Jul 30, 2018

#4396-app - Avoid another NPE
Pipes/Cabling vertical #4396

(cherry picked from commit 067bd46)
@metas-ts

This comment has been minimized.

Copy link
Member

commented Jul 30, 2018

🍒 picked NPE-Fix 067bd46 to release

@metas-ts metas-ts assigned metas-ts and unassigned metasnw Jul 31, 2018

metas-ts added a commit that referenced this issue Aug 1, 2018

metas-ts added a commit that referenced this issue Aug 1, 2018

#4396-app - make the system revalidate the discount schema break...
..when QtyEntered was changed
Pipes/Cabling vertical #4396

metas-ts added a commit to metasfresh/metasfresh-webui-frontend that referenced this issue Aug 1, 2018

#4396-app - add a spec that creates a discount schema
..when QtyEntered was changed
Pipes/Cabling vertical metasfresh/metasfresh#4396

metas-ts added a commit that referenced this issue Aug 1, 2018

#4396-app - minor cleanups
Pipes/Cabling vertical #4396

metas-ts added a commit that referenced this issue Aug 1, 2018

Merge pull request #4441 from metasfresh/gh4396-app
#4396-app - Pipes/Cabling vertical - update discounts
@metas-dh

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

was tested by metas-nw: OK, already rolled out at customer db

@metas-dh metas-dh closed this Aug 22, 2018

metas-ts added a commit that referenced this issue Oct 25, 2018

fix two regressions that were dicovered just now; thx @metas-dh
* fix "== vs. equals" related bug in OLCandsProcessorExecutor
* fix parameter-type bug in AttributeDAO

Pharma: MSV3 Purchase Functionality in purchase candidates #4033
Pipes/Cabling vertical #4396

metas-ts added a commit to metasfresh/metasfresh-e2e that referenced this issue Mar 11, 2019

#4396-app - add a spec that creates a discount schema
..when QtyEntered was changed
Pipes/Cabling vertical metasfresh/metasfresh#4396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.