Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests can not be saved II #4622

Closed
metasnw opened this issue Sep 21, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@metasnw
Copy link
Member

commented Sep 21, 2018

follow up to #4520

Is this a bug or feature request?

bug

What is the current behavior?

still a problem

Which are the steps to reproduce?

  1. open window 540354
  2. open any partner
  3. click new to create a new request
  4. save
  5. NOK: request is saved but without reference to the partner

other case:

  1. open user
  2. create a new token

in sum there are ~70 cases where this might be a problem

SELECT

  w.name as window_name,
  t.name as tab_name,
  f.name as field_name,
  tab.tablename,
  c.columnname,
  isparent,
  columnsql

FROM ad_window w
  JOIN ad_tab t ON t.ad_window_id = w.ad_window_id
  JOIN ad_field f ON f.ad_tab_id = t.ad_tab_id
  JOIN ad_table tab on tab.ad_table_id = t.ad_table_id
  JOIN ad_column c on f.ad_column_id = c.ad_column_id
WHERE true --w.name = 'Projekt so101'
  and t.ad_column_id = c.ad_column_id
  and isparent='N' and t.ad_column_id = c.ad_column_id
  and t.isreadonly ='N' and isinsertrecord = 'Y'
ORDER BY w.name

metasnw added a commit that referenced this issue Sep 25, 2018

#4622 fixing request and token tabs
#4622 setting parent link column

metas-ts added a commit that referenced this issue Sep 26, 2018

Merge pull request #4631 from metasfresh/gh4622
#4622 fixing request and token tabs

@metas-ts metas-ts added the bug label Sep 26, 2018

@metasnw

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2018

@metas-mk suggests to set the parent link column for all 60+ cases and set it in future for new linked tabs manually

@metas-ts

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

imho it's worthwhile spending 1-2hrs debugging the issue. i hope it's actually a small one.
@teosarca wdyt?

metas-ts added a commit that referenced this issue Sep 28, 2018

#4622 fixing request and token tabs
#4622 setting parent link column

(cherry picked from commit 23a8358)
@metas-ts

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

🍒 picked #4622 into release

metas-ts added a commit that referenced this issue Sep 28, 2018

Update ReleaseNotes.md
[#4622](#4622) Requests can not be saved II
[#4624](#4624) Invoice candidate not updated after shipment reactivate and complete
[#1972](metasfresh/metasfresh-webui-frontend#1972) Support active indication for filters without parameters

metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Oct 1, 2018

@metas-dh

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

checked with metas-nw: working fine on live, closing.

@metas-dh metas-dh closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.