Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice candidate not updated after shipment reactivate and complete #4624

Closed
metas-ts opened this issue Sep 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@metas-ts
Copy link
Member

commented Sep 24, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

@metas-ts metas-ts added the type:bug label Sep 24, 2018

@metas-ts metas-ts self-assigned this Sep 24, 2018

metas-ts added a commit that referenced this issue Sep 24, 2018

#4624-app - invoice candidate not updated after shipment complete
* invoice candidates are no longer invalidated when C_OrderLine.QtyDelivered changes; because this only catches ICs that have an order line
* instead they are invalidated on M_InOut completion (also reactivation, but we already had that before)

also
* IMRPProductInfoSelector et al: fix bug that no async prokpackage was created on M_Transaction delete (e.g. when a shipment was reactivated)
* ITrxManager add method isActive() also for String trxName
* CacheMgt, PostingRequestBuilder and TrxOnCommitCollectorFactory: use ITrxManager.isActive() instead of isNull(), to also handle the case of an already closed trx
* WorkPackageQueue.markReadyForProcessing() make *really* sure that the WP is unlocked at the end
* M_InOutLine move method that is not invoice-candidte-related to the general M_InOutLine interceptor
* InvoiceCandUpdateSchedulerRequest: cleanup

#4624

metas-ts added a commit that referenced this issue Sep 25, 2018

Merge pull request #4626 from metasfresh/gh4624-app
#4624-app - invoice candidate not updated after shipment complete

@metas-ts metas-ts added the bug label Sep 25, 2018

@metas-dh

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

Results of IT1
tested in mf15

  • ICs are updated correctly after shipment is reactivated and completed again: OK
  • invoice for the ICs is created correctly: OK
  • ICs are still updated correctly after invoice reversal: OK
  • invoice for the ICs is created correctly again after reversing: OK

@metas-dh metas-dh closed this Sep 26, 2018

metas-ts added a commit that referenced this issue Sep 28, 2018

#4624-app - invoice candidate not updated after shipment complete
* invoice candidates are no longer invalidated when C_OrderLine.QtyDelivered changes; because this only catches ICs that have an order line
* instead they are invalidated on M_InOut completion (also reactivation, but we already had that before)

also
* IMRPProductInfoSelector et al: fix bug that no async prokpackage was created on M_Transaction delete (e.g. when a shipment was reactivated)
* ITrxManager add method isActive() also for String trxName
* CacheMgt, PostingRequestBuilder and TrxOnCommitCollectorFactory: use ITrxManager.isActive() instead of isNull(), to also handle the case of an already closed trx
* WorkPackageQueue.markReadyForProcessing() make *really* sure that the WP is unlocked at the end
* M_InOutLine move method that is not invoice-candidte-related to the general M_InOutLine interceptor
* InvoiceCandUpdateSchedulerRequest: cleanup

#4624
(cherry picked from commit 122b622)
@metas-ts

This comment has been minimized.

Copy link
Member Author

commented Sep 28, 2018

🍒 picked metasfresh/metasfresh-webui-frontend#1972 to release****

@metas-ts metas-ts changed the title invoice candidate not updated after shipment reactivate and complete Invoice candidate not updated after shipment reactivate and complete Sep 28, 2018

metas-ts added a commit that referenced this issue Sep 28, 2018

Update ReleaseNotes.md
[#4622](#4622) Requests can not be saved II
[#4624](#4624) Invoice candidate not updated after shipment reactivate and complete
[#1972](metasfresh/metasfresh-webui-frontend#1972) Support active indication for filters without parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.