Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove M_Product_Category_ID from Material Cockpit #4640

Closed
metas-rc opened this issue Oct 1, 2018 · 4 comments
Closed

Option to remove M_Product_Category_ID from Material Cockpit #4640

metas-rc opened this issue Oct 1, 2018 · 4 comments

Comments

@metas-rc
Copy link
Member

@metas-rc metas-rc commented Oct 1, 2018

Is this a bug or feature request?

*FR

What is the current behavior?

  • Now the M_Product_Category_ID column is always displayed in the Material Cockpit.

Which are the steps to reproduce?

  • Check and see

What is the expected or desired behavior?

*Add a sys config de.metas.ui.web.material.cockpit.field.M_Product_Category_ID.IsDisplayed and change the code to display this column accordingly

@metas-rc metas-rc self-assigned this Oct 1, 2018
metas-rc added a commit that referenced this issue Oct 1, 2018
…_Category_ID or not

#4640
metas-rc added a commit to metasfresh/metasfresh-webui-api that referenced this issue Oct 1, 2018
metas-ts added a commit that referenced this issue Oct 2, 2018
#4640 sys config: option in Material Cockpit to display the M_Product…
@metas-rc metas-rc removed their assignment Oct 10, 2018
@metas-rc

This comment has been minimized.

Copy link
Member Author

@metas-rc metas-rc commented Oct 10, 2018

Notes for IT:

  • The sys config is called de.metas.ui.web.material.cockpit.field.M_Product_Category_ID.IsDisplayed
  • If the sys config's value is 'N', the column shall not be displayed in the Material Cockpit
  • If it's on 'Y' it shall be displayed.

Later edit: The sys config was renamed to

de.metas.ui.web.material.cockpit.field.productCategoryOrSubRowName.IsDisplayed
metas-ts added a commit that referenced this issue Oct 15, 2018
[#4609](#4609) HUEditor-Tweaks  * [#4633](#4633) Generic Process for SQL -> Excel Export
[#4636](#4636) Support attachments being linked to multiple records
[#4640](#4640) Option to remove M_Product_Category_ID from Material Cockpit
[#4646](#4646) Rename and extend AD_MigrationScript helper function
[#4646](#4649) BPartners FTS shall not be active by default
[#4659](#4659) Configurable Mailtext for Documents in DocOutbound
[#1063](metasfresh/metasfresh-webui-api#1063) Global QR Code Actions support
[#1066](metasfresh/metasfresh-webui-api#1066) Don't show KPIs if the ElasticSearch system is disabled
[#1990](metasfresh/metasfresh-webui-frontend#1990) QR code support
[#1999](metasfresh/metasfresh-webui-frontend#1999) Process execution result action: render QR code
[#4644](#4644) Clone Quotation, switch Sales Order. Wrong Document No
[#4650](#4650) Elasticsearch shall use slf4j instead of log4j (again)
[#4657](#4657) AD_Message cache in Msg not invalidated on data change
[#4658](#4658) Dunning jasper uses untranslated _trl records
[#1060](metasfresh/metasfresh-webui-api#1060) Allow parent-link relation to be set in AD_Tab
[#1998](metasfresh/metasfresh-webui-frontend#1998) Open view process action shall support profileId (frontend)
[#2000](metasfresh/metasfresh-webui-frontend#2000) Modal view shall query the quick actions initially
@metas-mk

This comment has been minimized.

Copy link
Member

@metas-mk metas-mk commented Oct 23, 2018

Quick check/ IT: Attribute Rows are still shown. Pls fix.

metas-rc added a commit that referenced this issue Oct 23, 2018
metas-rc added a commit to metasfresh/metasfresh-webui-api that referenced this issue Oct 23, 2018
metas-rc added a commit that referenced this issue Oct 23, 2018
@metas-rc

This comment has been minimized.

Copy link
Member Author

@metas-rc metas-rc commented Oct 23, 2018

There was a misunderstanding first. I understood I had add a display option for the product category column in Material Cockpit.
Actually, the task was about hiding the included rows in the Material Cockpit.
I aded an option for this via sys config. It is called de.metas.ui.web.material.cockpit.MaterialCockpitViewFactory.DisplayIncludedRows
If this sys config is on true, the included rows should be displayed. If it's on false, they should be hidden.

metas-ts added a commit that referenced this issue Oct 24, 2018
#4640 option to not see included rows in material cockpit
metas-rc added a commit that referenced this issue Oct 31, 2018
metas-ts added a commit that referenced this issue Nov 1, 2018
#4640 Product category sys config had the wrong name
@metas-dh

This comment has been minimized.

Copy link
Member

@metas-dh metas-dh commented Nov 5, 2018

Results of IT1
tested in mf15

  • new sysconfig: de.metas.ui.web.material.cockpit.MaterialCockpitViewFactory.DisplayIncludedRows: OK
  • when config is set Y, attribute rows are displayed: OK
  • when config is set N, attribute rows are not displayed: OK
@metas-dh metas-dh closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.