Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipment schedule not updated when asi in orderline is updated #4870

Closed
metas-dh opened this issue Jan 16, 2019 · 1 comment
Closed

Shipment schedule not updated when asi in orderline is updated #4870

metas-dh opened this issue Jan 16, 2019 · 1 comment

Comments

@metas-dh
Copy link
Member

@metas-dh metas-dh commented Jan 16, 2019

Is this a bug or feature request?

Bug

What is the current behavior?

When you reactivate a sales order and update an orderline (in my case, add asi) the corresponding shipment schedule is not updated as well.

Which are the steps to reproduce?

  1. Create a sales order with some orderlines
  2. Complete, check shipment schedule: OK
  3. Reactivate the order, and add asi to an orderline, complete again
  4. Check the shipment schedule: not updated => problematic in picking terminal bc the asi is not considered for picking: NOK

What is the expected or desired behavior?

Shipment schedule shall be updated after orderline was updated.

@metas-dh metas-dh added the type:bug label Jan 16, 2019
metas-ts added a commit that referenced this issue Dec 21, 2019
* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960
metas-ts added a commit that referenced this issue Dec 21, 2019
(the failing tests were addressed)

* Shipmentschedule not updated after order reactivate and re-complete

* close and open affected shipment schedules as the respective sales order is reactivated and completed again

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* when opening a shipment schedule, then also update with stuff from the respective referenced object
* cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments
#5960

* Shipmentschedule not updated after order reactivate and re-complete

* prevent reactivation if shipment schedule is already processed
#5960

* fix unit test

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960
metas-ts added a commit that referenced this issue Dec 21, 2019
(the failing tests were addressed)

* Shipmentschedule not updated after order reactivate and re-complete

* close and open affected shipment schedules as the respective sales order is reactivated and completed again

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* when opening a shipment schedule, then also update with stuff from the respective referenced object
* cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments
#5960

* Shipmentschedule not updated after order reactivate and re-complete

* prevent reactivation if shipment schedule is already processed
#5960

* fix unit test

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960

(cherry picked from commit 3541ee9)
@metas-dh

This comment has been minimized.

Copy link
Member Author

@metas-dh metas-dh commented Jan 7, 2020

checked in releasetest:
this was fixed by the task mentioned above. closing.

@metas-dh metas-dh closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.