Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment discount when importing discount schema #4913

Closed
cristinamghita opened this issue Jan 29, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@cristinamghita
Copy link
Member

commented Jan 29, 2019

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

@cristinamghita cristinamghita self-assigned this Jan 29, 2019

cristinamghita added a commit that referenced this issue Jan 30, 2019

#4913 Set payment discount
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Jan 30, 2019

#4913 Do not allow duplicates of the same product with same values in…
… the same discount schema

Add payment discount when importing discount schema #4913

cristinamghita added a commit that referenced this issue Jan 30, 2019

#4913 Add payment discount when importing discount schema
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Jan 31, 2019

#4913 Fix NPE
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Jan 31, 2019

#4913 cast correctly from Number to BigDecimal
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Feb 5, 2019

#4913 clean
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Feb 26, 2019

#4913 Add discount field
#4913 Add payment discount when importing discount schema

cristinamghita added a commit that referenced this issue Feb 28, 2019

#4913 Use alias for ambiguous column
#4913 Add payment discount awhen importing discount schema

Co-Authored-By: cristinamghita <cristina.ghita@metasfresh.com>

cristinamghita added a commit that referenced this issue Feb 28, 2019

#4913 Filter for IsActive='Y'
#4913 Add payment discount when importing discount schema

Co-Authored-By: cristinamghita <cristina.ghita@metasfresh.com>

metas-ts added a commit that referenced this issue Feb 28, 2019

Merge pull request #4917 from metasfresh/gh4913
 #4913 Add payment discount when importing discount schema

@metas-ts metas-ts added the bug label Feb 28, 2019

@metas-dh

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Results of IT1
tested in IT

  • Import Discount Schema with Discount set: 3%, OK
  • Discount Schema: Discount Schema Lines have Skonto: 3% set, OK
  • in Import Discount Schema, it's called "Rabatt", although it is in fact "Skonto": in Discount Schema Lines it's "Skonto", so that's OK

@metas-dh metas-dh closed this Feb 28, 2019

metas-ts added a commit that referenced this issue Mar 4, 2019

Update ReleaseNotes.md
  * [#4913](#4913) Add payment discount when importing discount schema
  * [#4961](#4961) Chart of Accounts Import
  * [#4988](#4988) Improve async workpackage logging for shipment schedule and invoice candidate updating
  * [#4991](#4991) URL csv Importer for BPartner
  * [#4997](#4997) Handle M_DiscountSchemaBreak with PriceBase=P(ricingSystem) & missing Base_PricingSystem_ID
  * [#5001](#5001) Create a table for storing product certificate informations
  * [#2197](metasfresh/metasfresh-webui-frontend#2197) Don't show input field for QR reader on mobile
  * [#4966](#4966) Prolonging contract does not working anymore
  * [#4975](#4975) LastShipmentDate not displayed anymore in Products Proposal
  * [#4985](#4985) MemorizingSupplier.get returns null while it actually couldn't
  * [#4987](#4987) M_Attribute_Value is not saved correctly
  * [#4989](#4989) Problem posting documents with zero-amounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.