Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M_DiscountSchemaBreak.PriceBase shall be nullable #4976

Closed
teosarca opened this issue Feb 21, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@teosarca
Copy link
Member

commented Feb 21, 2019

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

  • open discount schema (aka pricing conditions)
  • try to create/change a break
  • try to change the PriceBase from Pricing System (or maybe Fixed pricing) to empty ... because you just want to give a discount but not override the normal price
    => you cannot, PriceBase is mandatory

What is the expected or desired behavior?

It shall not be mandatory.

@metas-dh

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Results of IT1
tested in mf15

  • M_DiscountSchemaBreak.PriceBase shall be nullable: OK
  • M_DiscountSchemaBreak is valid and saved correctly when M_DiscountSchemaBreak.PriceBase is null:
    • M_DiscountSchemaBreak is marked as valid, OK
    • but when you try to close the modal, the M_DiscountSchemaBreak is not saved obviously: NOK

2019-02-21 10_44_59-metasfresh

  • after closing the modal, no M_DiscountSchemaBreak exists with M_DiscountSchemaBreak.PriceBase=null: NOK

@teosarca teosarca assigned cristinamghita and unassigned teosarca Feb 21, 2019

cristinamghita added a commit that referenced this issue Feb 21, 2019

#4976 Fix mandatory logic for currency and basepricingsystem
#4976 M_DiscountSchemaBreak.PriceBase shall be nullable

teosarca added a commit that referenced this issue Feb 22, 2019

Merge pull request #4980 from metasfresh/gh4976_1
#4976 Fix mandatory logic for currency and basepricingsystem
@metas-dh

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Results of IT2
tested in mf15

  • M_DiscountSchemaBreak is valid and saved correctly when M_DiscountSchemaBreak.PriceBase is null: no error, OK
  • after closing the modal, the M_DiscountSchemaBreak exists with M_DiscountSchemaBreak.PriceBase=null: OK

@metas-dh metas-dh closed this Feb 22, 2019

metas-ts added a commit that referenced this issue Feb 25, 2019

update ReleaseNotes.md
  * [#4967](#4967) Warehouse Customization: Picking
  * [#1154](metasfresh/metasfresh-webui-api#1154) Take out "Back" action from quick actions in "More products..." modal
  * [#1155](metasfresh/metasfresh-webui-api#1155) Support providing shortcuts for processes
  * [#2182](metasfresh/metasfresh-webui-frontend#2182) Back button for modals
  * [#2183](metasfresh/metasfresh-webui-frontend#2183) frontend: Scan using camera shall be translatable
  * [#2193](metasfresh/metasfresh-webui-frontend#2193) View quick actions: provide viewProfileId when calling /quickActions endpoint
  * [#4964](#4964) Services.get(IDocumentNoBuilderFactory.class) calls the wrong constructor
  * [#4976](#4976) M_DiscountSchemaBreak.PriceBase shall be nullable
  * [#57](metasfresh/metasfresh-dist#57) PostgreSQL applying our migration scripts not working anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.