Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPartner REST-API - Add Support for additional core fields #5364

Open
metas-ts opened this issue Jul 4, 2019 · 2 comments

Comments

@metas-ts
Copy link
Member

commented Jul 4, 2019

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

metas-ts added a commit that referenced this issue Jul 4, 2019

5364-app - Add Support for additional core fields
general improvements
* JsonRetrieverService - fix NPE-bug when a location has no GLN
* RestResponseEntityExceptionHandler - also write exceptions to the log
* JsonResponseBPartner, JsonResponseContact, JsonResponseLocation - make sure that the changeInfo is last (cosmetic)

#5364

metas-ts added a commit that referenced this issue Jul 4, 2019

5364-app - Add Support for additional core fields
general improvements
* JsonRetrieverService - fix NPE-bug when a location has no GLN
* RestResponseEntityExceptionHandler - also write exceptions to the log
* JsonResponseBPartner, JsonResponseContact, JsonResponseLocation - make sure that the changeInfo is last (cosmetic)

#5364
(cherry picked from commit b28b545)
@metas-ts

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

  • C_Location.Address3
  • C_Location.Address4
  • C_BPartner.Name2

@metas-ts metas-ts closed this Jul 4, 2019

@metas-ts metas-ts reopened this Jul 4, 2019

@metas-ts

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

Generally: also GET inactive records

All fields to add (incl the ones above)

BPartner

  • Name2
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Name3
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • URL2 (is not yet a core field! but we have URL and URL3)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • URL3
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsActive ('C_BPartner.IsActive`)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Qualification (C_BPartner.Qualification)
    • currently not needed after all
  • ShortDescription (C_BPartner.ShortDescription)
    • currently not needed after all

Location

  • Name ('C_BPartner_Location.Name`)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsBillToDefault
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsShipToDefault
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsBillTo
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsShipTo
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Address3 (C_Location.Address3)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Address4 (C_Location.Address4)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsActive (C_BPartner_Location.IsActive)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService

Contact

  • IsDefaultContact
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • billToDefault
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • shipToDefault
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • sales (AD_User.IsSalesContact)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • salesDefault (AD_User.IsSalesContact_Default)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • purchase (AD_User.IsPurchaseContact)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • purchaseDefault (AD_User.IsPurchaseContact_Default)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • subjectMatter (AD_User.IsSubjectMatter)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsActive
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • IsNewsLetter (AD_User.IsNewsLetter)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Fax (AD_User.Fax)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • MobilePhone (AD_User.MobilePhone)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Description (AD_User.Description)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService
  • Anrede ('AD_User.C_Greeting.Name`)
    • BPartnerCompositeRepository
    • JsonPersisterService
    • JsonRetrieverService

metas-ts added a commit that referenced this issue Jul 17, 2019

5364-app - Add Support for additional core fields
- add a bunch of additional properties to the BPartner model
- add C_BPartner.URL2
  - recreate I_/X_C_BPartner class which now has less "record-getters" => adapt other classes to that change
- add modest beginnings of greeting model
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- add a bunch of additional properties to the BPartner model
- add C_BPartner.URL2
  - recreate I_/X_C_BPartner class which now has less "record-getters" => adapt other classes to that change
- add modest beginnings of greeting model
#5364

(cherry picked from commit e5e78a7)

solved Conflicts:
	de.metas.business/src/main/java/de/metas/bpartner/composite/BPartnerComposite.java

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
fix NPE and improve error message
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
backport after CP, to fix compiler error
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
cleanup duplicate classes - thx maven enforcer!
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
cleanup duplicate classes - thx maven enforcer!
#5364

(cherry picked from commit 77f59ee)

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- fix a bug in BPartnerCompositeCache
- extend CCache framework by adding CacheAdditionListener; that way, the bug i fixed won't happen again
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- fix request location serialization (don't include null value flags)
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- fix a bug in BPartnerCompositeCache
- extend CCache framework by adding CacheAdditionListener; that way, the bug i fixed won't happen again
#5364

(cherry picked from commit ee17fc2)

solved Conflicts:
	de.metas.adempiere.adempiere/base/src/main/java-legacy/org/compiere/model/PO.java

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- fix request location serialization (don't include null value flags)
#5364

(cherry picked from commit 54eaef9)

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- add additional contact related flags
  - sales
  - salesDefault
  - purchase
  - purchaseDefault
  - subjectMatter
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- add all new properties to the change log
- split JsonPersisterService into multiple java files
- make sure that if one location or cantact is set to be the default, all others are unset
-
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- add additional contact related flags
  - sales
  - salesDefault
  - purchase
  - purchaseDefault
  - subjectMatter
#5364

(cherry picked from commit b8686b0)

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- add all new properties to the change log
- split JsonPersisterService into multiple java files
- make sure that if one location or cantact is set to be the default, all others are unset
-
#5364

(cherry picked from commit 2a73be8)

solved Conflicts:
	de.metas.business.rest-api-impl/src/main/java/de/metas/rest_api/bpartner/impl/bpartnercomposite/jsonpersister/JsonPersisterService.java

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
backport after CP, to fix compiler error
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- BPartnerCompositeRepository - update full-address-string and fix country-related issue
- CacheIndex - fix ConcurrentModificationException
- DataEntryRecordCache - cleanup
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- fixes wrt activation and deactivation of records
#5364

metas-ts added a commit that referenced this issue Jul 18, 2019

5364-app - Add Support for additional core fields
- changing the column-length of C_BPartner.URL is too much hassle
#5364

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- cleanup/introduce more constants to make the code clearer and extending it less error-prone
- solve unit test errors
- order json properties alphabetically, hoping to make json-snapshot files more "stable"
#5364

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- BPartnerCompositeRepository - update full-address-string and fix country-related issue
- CacheIndex - fix ConcurrentModificationException
- DataEntryRecordCache - cleanup
#5364

(cherry picked from commit a36a034)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- fixes wrt activation and deactivation of records
#5364

(cherry picked from commit d489ac6)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- changing the column-length of C_BPartner.URL is too much hassle
#5364

(cherry picked from commit a5622ad)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- cleanup/introduce more constants to make the code clearer and extending it less error-prone
- solve unit test errors
- order json properties alphabetically, hoping to make json-snapshot files more "stable"
#5364

(cherry picked from commit 1738c51)

solved Conflicts:
	de.metas.business/src/main/java/de/metas/bpartner/composite/BPartner.java

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- changing the column-length of C_BPartner.URL3 is too much hassle
#5364

metas-ts added a commit that referenced this issue Jul 19, 2019

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- changing the column-length of C_BPartner.URL3 is too much hassle
#5364

(cherry picked from commit 7ede51f)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- minor
#5364

(cherry picked from commit 2e1d361)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- bugfix regarding a different sync advise for locations or contacts
- cleanup
#5364

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- bugfix regarding a different sync advise for locations or contacts
- cleanup
#5364

(cherry picked from commit f1154dc)

solved Conflicts:
	de.metas.business/src/main/java/de/metas/bpartner/composite/BPartnerComposite.java
	de.metas.business/src/main/java/de/metas/bpartner/composite/BPartnerLocation.java

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- bugfix where locations and contacts where created although they already existed
#5364

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
- bugfix where locations and contacts where created although they already existed
#5364

(cherry picked from commit c612289)

metas-ts added a commit that referenced this issue Jul 19, 2019

5364-app - Add Support for additional core fields
fix NPE and improve error message
#5364

(cherry picked from commit 0255c62)

metas-ts added a commit that referenced this issue Jul 22, 2019

Update ReleaseNotes.md
  * [#5364](#5364) BPartner REST-API - Add Support for additional core fields
  * [#5390](#5390) Add Quality Issue warehouse filter in Warehouse list page
  * [#5370](#5370) Introduce more webui WidgetSizes (XL, XXL)
  * [#2304](metasfresh/metasfresh-webui-frontend#2304) Picking Terminal (Prototype): not all picking slots not displayed / close when clicking outside
  * [#2307](metasfresh/metasfresh-webui-frontend#2307) Set precision to 2 digits for `CableLength` field
  * [#46](metasfresh/metasfresh-e2e#46) Create test: warehouse
  * [#121](metasfresh/metasfresh-e2e#121) Create new Stock Control Purchase
  * [#126](metasfresh/metasfresh-e2e#126) Create Empties Receive
  * [#129](metasfresh/metasfresh-e2e#129) Create Dunning Candidates
  * [#130](metasfresh/metasfresh-e2e#130) Create Dunning Documents
  * [#132](metasfresh/metasfresh-e2e#132) Void sales invoice and invoice the billing candidates again
  * [#162](metasfresh/metasfresh-e2e#162) Create credit memo Vendor (Lieferant)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.