Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafted PP Orders shall not create demands #5423

Closed
teosarca opened this issue Aug 14, 2019 · 0 comments

Comments

@teosarca
Copy link
Member

commented Aug 14, 2019

Is this a bug or feature request?

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

@teosarca teosarca self-assigned this Aug 14, 2019

teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit to metasfresh/metasfresh-webui-api that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
This was referenced Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 14, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 15, 2019
MPPOrder: set DocStatus=CO before firing AFTER_COMPLETE
else, the PPOrderChangedEvent.isJustCompleted() will always return false.
(i.e. on completion the newDocStatus=IP, oldDocStatus=DR)

#5423
teosarca added a commit that referenced this issue Aug 15, 2019
teosarca added a commit that referenced this issue Aug 16, 2019
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- improve logging
- minor modernizations (DDOrderPojoSupplier in particular)
#5423
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- rename method of RequestMaterialOrderService to requestMaterialOrderFromCandidates() to make it clearer what the method does.
- bugfix: don't try to request a PPOrder using not-yet-existing candidates; instead, use the advise-event's PPOrder
#5423
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- solve compile errors
- minor logging improvements
#5423
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- unrealated: specify ordering in the swagger documentation of JsonRequestComposite (have already accidentally committed similar stuff in this branch)
#5423
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- fix bug with PPOrder that had no bpartnerID
- more logging
#5423
metas-ts added a commit that referenced this issue Aug 28, 2019
5423-app - Drafted PP Orders shall not create demands
- more logging
- fix: PPOrderAdvisedHandler needs to provide the groupId to the PPOrderRequestedEvent
- fix: PPOrderChangedEvent had the old type name "PPOrderQtyChangedEvent"
#5423
metas-ts added a commit that referenced this issue Aug 29, 2019
5423-app - Drafted PP Orders shall not create demands
- log improvements when handling events
- semi-related: changelog-info reacts gracefully to CreatedBy/UpdatedBy < 0 (i.e. unknown), which we don't rule out when saving records in the DB
#5423
metas-ts added a commit that referenced this issue Aug 29, 2019
5423-app - Drafted PP Orders shall not create demands
attempt (QA pending) to
- update PP_Order docstatus in Produktionsdetail  tab on a PPOrderchangeEvent
- set advised correctly in ProductionDetail tab
- set PP_Order.C_Order_ID (also project-id) on follow-up PPOrders (direct and indirect follow-ups!)
- set MD_Candidate.C_Order_ID (also other fields e.g. M_ShipmentSchedule) on follow-up PPOrders
#5423
metas-ts added a commit that referenced this issue Aug 29, 2019
5423-app - Drafted PP Orders shall not create demands
Drop S_Resource.M_Warehouse_ID:
* it's not used in the code or in a view;
* we have M_Warehouse.S_Resource (which is used)
#5423
metas-ts added a commit that referenced this issue Aug 29, 2019

@metas-ts metas-ts closed this in 496b95b Aug 29, 2019

metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- improve logging
- minor modernizations (DDOrderPojoSupplier in particular)
#5423

(cherry picked from commit a02c18d)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- rename method of RequestMaterialOrderService to requestMaterialOrderFromCandidates() to make it clearer what the method does.
- bugfix: don't try to request a PPOrder using not-yet-existing candidates; instead, use the advise-event's PPOrder
#5423

(cherry picked from commit bc70cdc)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- solve compile errors
- minor logging improvements
#5423

(cherry picked from commit 6083006)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- unrealated: specify ordering in the swagger documentation of JsonRequestComposite (have already accidentally committed similar stuff in this branch)
#5423

(cherry picked from commit 8a64b98)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- fix bug with PPOrder that had no bpartnerID
- more logging
#5423

(cherry picked from commit 2f3deb2)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- more logging
- fix: PPOrderAdvisedHandler needs to provide the groupId to the PPOrderRequestedEvent
- fix: PPOrderChangedEvent had the old type name "PPOrderQtyChangedEvent"
#5423

(cherry picked from commit db8b82a)
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
- log improvements when handling events
- semi-related: changelog-info reacts gracefully to CreatedBy/UpdatedBy < 0 (i.e. unknown), which we don't rule out when saving records in the DB
#5423

(cherry picked from commit 6ce3979)

solved Conflicts:
	de.metas.adempiere.adempiere/base/src/main/java/org/adempiere/ad/table/RecordChangeLogEntryLoader.java
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
attempt (QA pending) to
- update PP_Order docstatus in Produktionsdetail  tab on a PPOrderchangeEvent
- set advised correctly in ProductionDetail tab
- set PP_Order.C_Order_ID (also project-id) on follow-up PPOrders (direct and indirect follow-ups!)
- set MD_Candidate.C_Order_ID (also other fields e.g. M_ShipmentSchedule) on follow-up PPOrders
#5423

(cherry picked from commit 5e945c0)
metas-ts added a commit that referenced this issue Sep 2, 2019
metas-ts added a commit that referenced this issue Sep 2, 2019
5423-app - Drafted PP Orders shall not create demands
Drop S_Resource.M_Warehouse_ID:
* it's not used in the code or in a view;
* we have M_Warehouse.S_Resource (which is used)
#5423

(cherry picked from commit 526066b)
metas-ts added a commit that referenced this issue Sep 2, 2019
Apply suggestions from code review
#5423

(cherry picked from commit d2d2f5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.