Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `ExternalId` to Product #5575

Closed
metas-ts opened this issue Sep 25, 2019 · 1 comment

Comments

@metas-ts
Copy link
Member

@metas-ts metas-ts commented Sep 25, 2019

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

Extend M_Product

  • add column and field for ExternalId
  • add externalId to the product REST endpoint
  • add externalId to the order-candidates REST endpoint
  • enable inventory import to lookup via ProductValue="ext-(SomeExternalId)"
  • also add ExternalId to I_I_Product
    • for feature predictability and consistency
metas-ts added a commit that referenced this issue Sep 25, 2019
* add ExternalId to M_Product and I_Product
* inventory-import: add support to match products via I_Inventory.ProductValue also by ExternalId (prefix "ext-")
* refactoring: when i recreate the model classes, some getter were gone, so i refactored where necessary
* cleanup: got rid of deprecated I_M_Product_Category.java
#5575
metas-ts added a commit that referenced this issue Sep 25, 2019
add migration scripts for
* ExternalId columns, fields & stuff
* fix inventory import menu to be similar to the other menu names
#5575
metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Sep 26, 2019
* refactoring: when i recreate the model classes, some getter were gone, so i refactored where necessary
metasfresh/metasfresh#5575
@metas-ts

This comment has been minimized.

Copy link
Member Author

@metas-ts metas-ts commented Oct 1, 2019

Dev-Test

  • inventory import with ext-blablabal productValue works
  • the response to a GET to products-rest-controller EP contains externalId, if set in the product's master data
  • we can do externalId based product lookups in the order-candidates-rest-controller
metas-ts added a commit that referenced this issue Oct 2, 2019
metas-ts added a commit that referenced this issue Oct 3, 2019
add externalId to product masterdata lookup
#5575
metas-ts added a commit to metasfresh/metasfresh-webui-api that referenced this issue Oct 3, 2019
metas-ts added a commit that referenced this issue Oct 3, 2019
fix regarding product import
#5575
metas-ts added a commit to metasfresh/metasfresh-talend that referenced this issue Oct 7, 2019
adapt sh file to that semi-conscious package name change i did last week
metasfresh/metasfresh#5575
@metas-ts metas-ts closed this Oct 8, 2019
metas-ts added a commit that referenced this issue Oct 14, 2019
  * [#5575](#5575) Add `ExternalId` to Product
  * [#5589](#5589) New Window for BOM Components & Reference to BOM
  * [#5592](#5592) Show warehouse search key value in Grid View
  * [#5609](#5609) persistent object: log warning if changing an PO on after new/change
  * [#5616](#5616) New Tab Ingredients in Product window
  * [#5620](#5620) Set automatically Name field from AD_UI_Element
  * [#5625](#5625) Material Tracking - change quality discount base
  * [#5639](#5639) Print Picklist from Picking terminal v2
  * [#5645](#5645) BOM Components followup - Comment, Change notice and Expected result to be added
  * [#5564](#5564) Import Process Performance
  * [#5644](#5644) Action: Update Invoice Location and contact for all selected lines
  * [#5649](#5649) GTIN in Product window
  * [#5652](#5652) OLCand - support requests without BPartner-Location
  * [#5598](#5598) NPE Async for sending email from DocOutbound
  * [#5599](#5599) No invoice from Picking Terminal 2: NetAmtToInvoice checksum not match
  * [#5600](#5600) No invoice bc of QuantitiesUOMNotMatchingExpection
  * [#5613](#5613) Partner relations for invoice location allows only one invoice receipient
  * [#5615](#5615) Ad_tab fix `ModelValidator.TYPE_AFTER_NEW, ModelValidator.TYPE_AFTER_CHANGE` error
  * [#5617](#5617) bugfix wrt bpartner-lookup just via GLN
  * [#5629](#5629) Can't create a new order
  * [#1270](metasfresh/metasfresh-webui-api#1270) Org-ID not found Callout error
  * [#2394](metasfresh/metasfresh-webui-frontend#2394) Rounded corners missing in mandatory fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.