Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLCand - support requests without BPartner-Location #5652

Closed
metas-ts opened this issue Oct 10, 2019 · 0 comments

Comments

@metas-ts
Copy link
Member

@metas-ts metas-ts commented Oct 10, 2019

Is this a bug or feature request?

FR

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

If there is no bpartner location specified, the system shall fall back to a metasfresh-address, prefering the default-shipto-address

metas-ts added a commit that referenced this issue Oct 10, 2019
add fallback code and swagger documentation
#5652
metas-ts added a commit that referenced this issue Oct 10, 2019
- unit test fixes and refactoring
- do the lookup/fallback in masterdataprovider; OLCandRepository is the wrong place to do such on-the-fly-lookup stuff
- IBPartnerDAO - BPartnerLocationQuery to retrieve location with different type if the desired type is not available
#5652
metas-ts added a commit that referenced this issue Oct 10, 2019
- fix minor docu typo
#5652
metas-ts added a commit that referenced this issue Oct 10, 2019
- unit test for the new BPartnerLocationQuery property
#5652
metas-ts added a commit that referenced this issue Oct 10, 2019
- after Merge branch 'gh5652-app' into gh5628_1
- fix after-merge compile error on other minor thing
#5643 #5652
metas-ts added a commit that referenced this issue Oct 11, 2019
- fix a bug i saw in review
- refactiored tests for better extensibility
#5652
metas-ts added a commit that referenced this issue Oct 11, 2019
- add class for "refactored tests for better extensibility"
#5652
metas-ts added a commit that referenced this issue Oct 11, 2019
- minor nice refactoring (can just be merged into master later)
#5652
metas-ts added a commit that referenced this issue Oct 11, 2019
- fix bugs after review; reduce FUD by extending my unit test
#5652
@metas-ts metas-ts closed this Oct 14, 2019
metas-ts added a commit that referenced this issue Oct 14, 2019
  * [#5575](#5575) Add `ExternalId` to Product
  * [#5589](#5589) New Window for BOM Components & Reference to BOM
  * [#5592](#5592) Show warehouse search key value in Grid View
  * [#5609](#5609) persistent object: log warning if changing an PO on after new/change
  * [#5616](#5616) New Tab Ingredients in Product window
  * [#5620](#5620) Set automatically Name field from AD_UI_Element
  * [#5625](#5625) Material Tracking - change quality discount base
  * [#5639](#5639) Print Picklist from Picking terminal v2
  * [#5645](#5645) BOM Components followup - Comment, Change notice and Expected result to be added
  * [#5564](#5564) Import Process Performance
  * [#5644](#5644) Action: Update Invoice Location and contact for all selected lines
  * [#5649](#5649) GTIN in Product window
  * [#5652](#5652) OLCand - support requests without BPartner-Location
  * [#5598](#5598) NPE Async for sending email from DocOutbound
  * [#5599](#5599) No invoice from Picking Terminal 2: NetAmtToInvoice checksum not match
  * [#5600](#5600) No invoice bc of QuantitiesUOMNotMatchingExpection
  * [#5613](#5613) Partner relations for invoice location allows only one invoice receipient
  * [#5615](#5615) Ad_tab fix `ModelValidator.TYPE_AFTER_NEW, ModelValidator.TYPE_AFTER_CHANGE` error
  * [#5617](#5617) bugfix wrt bpartner-lookup just via GLN
  * [#5629](#5629) Can't create a new order
  * [#1270](metasfresh/metasfresh-webui-api#1270) Org-ID not found Callout error
  * [#2394](metasfresh/metasfresh-webui-frontend#2394) Rounded corners missing in mandatory fields
metas-ts added a commit that referenced this issue Oct 14, 2019
- resolve currently remaining compile error
- i think as a next step i need to create the contracts stuff
#5652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.