Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint: get invoice PDF #5786

Closed
metas-rc opened this issue Nov 13, 2019 · 1 comment

Comments

@metas-rc
Copy link
Member

@metas-rc metas-rc commented Nov 13, 2019

Is this a bug or feature request?

  • endpoint for getting the invoice report as PDF

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

Some thoughts

  • (this is how the webui-API does it's printing: de.metas.ui.web.window.model.DocumentCollection.createDocumentPrint(DocumentPath))
  • => but we could also return the invoice's AD_Archive..i think that's better...it's created anyways
    • we can always return the PDF of the latest AD_Archive that references the invoice or ofc 404 if there is none
  • also, include info (a reference even?) to the invoice's AD_Archive in the invoice candidate status info!

the method could look like this

	@GetMapping("/{invoiceId}/pdf")
	@Override
	public ResponseEntity<byte[]> getInvoicePDF(@PathVariable MetasfreshId invoiceId)
	{
		// TODO Auto-generated method stub
		return null;
	}
metas-rc added a commit that referenced this issue Nov 14, 2019
metas-rc added a commit that referenced this issue Nov 15, 2019
@metas-rc

This comment has been minimized.

Copy link
Member Author

@metas-rc metas-rc commented Nov 15, 2019

Docu

  • Endpoint:

image

  • Result

image

  • Downloaded file:

image

  • Call for invoice with no PDF

image

  • Result

image

  • Call for an invoice which does not exist

image

  • Result

image

  • Invoice candidate status for an invoice candidate which was invoiced and the invoice has a PDF

image

  • Result

image

  • Invoice candidate status for an invoice candidate which was invoiced and the invoice has NO PDF

image

metas-rc added a commit that referenced this issue Nov 18, 2019
@metas-ts metas-ts closed this Nov 25, 2019
metas-ts added a commit that referenced this issue Nov 25, 2019
  * [#5626](#5626) Support C_OLCands without UOM
  * [#5679](#5679) Trading BOM
  * [#5786](#5786) Endpoint: get invoice PDF
  * [#5797](#5797) Fix DB-function altercolumn to not fail on materialized views
  * [#5801](#5801) make invoice candidate updating robust to missing price
  * [#5804](#5804) BPartner Name overwrite in BPartner Location
  * [#5814](#5814) Introduce C_OrderLine.ExplodedFrom_BOMLine_ID
  * [#1303](metasfresh/metasfresh-webui-api#1303) shipment schedules edit modal: order rows by order and order line
  * [#1305](metasfresh/metasfresh-webui-api#1305) shipment schedule editor: pimp layout + show packing instructions
  * [#1307](metasfresh/metasfresh-webui-api#1307) products proposal: optimize layout for better usability
  * [#1311](metasfresh/metasfresh-webui-api#1311) product proposal: add Description field and make it editable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.