Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipmentschedule not updated after order reactivate and re-complete #5960

Open
metas-ts opened this issue Dec 20, 2019 · 0 comments
Open

Shipmentschedule not updated after order reactivate and re-complete #5960

metas-ts opened this issue Dec 20, 2019 · 0 comments

Comments

@metas-ts
Copy link
Member

@metas-ts metas-ts commented Dec 20, 2019

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

metas-ts added a commit that referenced this issue Dec 20, 2019
* close and open affected shipment schedules as the respective sales order is reactivated and completed again

#5960
metas-ts added a commit that referenced this issue Dec 20, 2019
* when opening a shipment schedule, then also update with stuff from the respective referenced object
* cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments
#5960
metas-ts added a commit that referenced this issue Dec 20, 2019
* prevent reactivation if shipment schedule is already processed
#5960
metas-ts added a commit that referenced this issue Dec 20, 2019
metas-ts added a commit that referenced this issue Dec 21, 2019
* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960
metas-ts added a commit that referenced this issue Dec 21, 2019
(the failing tests were addressed)

* Shipmentschedule not updated after order reactivate and re-complete

* close and open affected shipment schedules as the respective sales order is reactivated and completed again

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* when opening a shipment schedule, then also update with stuff from the respective referenced object
* cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments
#5960

* Shipmentschedule not updated after order reactivate and re-complete

* prevent reactivation if shipment schedule is already processed
#5960

* fix unit test

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960
metas-ts added a commit that referenced this issue Dec 21, 2019
(the failing tests were addressed)

* Shipmentschedule not updated after order reactivate and re-complete

* close and open affected shipment schedules as the respective sales order is reactivated and completed again

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* when opening a shipment schedule, then also update with stuff from the respective referenced object
* cleanup: IShipmentScheduleHandlerBL.invalidateCandidatesFor became obsolete with the rise of storage segments
#5960

* Shipmentschedule not updated after order reactivate and re-complete

* prevent reactivation if shipment schedule is already processed
#5960

* fix unit test

#5960

* Shipmentschedule not updated after order reactivate and re-complete

* also create or extend shipment schedule's ASI (#4870)
  * attribute instances of the shipment schedule that are not part of the order line's ASI are left untouched
* generally update everything (product, warehouse, bpartner etc) from the order line and its order, when the order line is completed again
#5960

(cherry picked from commit 3541ee9)
metas-ts added a commit that referenced this issue Dec 21, 2019
* fix unit tests
#5960

(cherry picked from commit c28962c)
metas-ts added a commit that referenced this issue Jan 17, 2020
Left-and-right improvements;
* ModelValidationEngine improve logging by adding MDCs
* IShipmentSchedulesAfterFirstPassUpdater implementors:
  * fix/modernize variable names
  * improve logging
  * change return value from int to void (was inconsistent anyways)

#5960
@metas-ts metas-ts mentioned this issue Jan 17, 2020
metas-ts added a commit that referenced this issue Jan 17, 2020
Compile error fix after left-and-right improvements;
#5960
metas-ts added a commit that referenced this issue Jan 17, 2020
another fix after left-and-right improvements;
#5960
metas-ts added a commit that referenced this issue Jan 17, 2020
minor loggin improvements during debugging
#5960
metas-ts added a commit that referenced this issue Jan 21, 2020
metas-ts added a commit that referenced this issue Jan 22, 2020
Left-and-right improvements;
* ModelValidationEngine improve logging by adding MDCs
* IShipmentSchedulesAfterFirstPassUpdater implementors:
  * fix/modernize variable names
  * improve logging
  * change return value from int to void (was inconsistent anyways)

#5960

(cherry picked from commit ea34233)

solved Conflict:
	de.metas.adempiere.adempiere/base/src/main/java-legacy/org/compiere/model/ModelValidationEngine.java
metas-ts added a commit that referenced this issue Jan 22, 2020
Compile error fix after left-and-right improvements;
#5960

(cherry picked from commit 37b26b4)

solved Conflict:
	de.metas.adempiere.adempiere/base/src/main/java-legacy/org/compiere/model/ModelValidationEngine.java
metas-ts added a commit that referenced this issue Jan 22, 2020
another fix after left-and-right improvements;
#5960

(cherry picked from commit 4cc538d)
metas-ts added a commit that referenced this issue Jan 22, 2020
minor loggin improvements during debugging
#5960

(cherry picked from commit 01692ca)
metas-ts added a commit that referenced this issue Jan 22, 2020
#5960

(cherry picked from commit 3723327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.