Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataentry via Rest-API #5180

Merged
merged 61 commits into from May 14, 2019

Conversation

Projects
None yet
4 participants
@TheBestPessimist
Copy link
Member

commented May 8, 2019

Implement endpoint for dataentry

Ref: #5162

TheBestPessimist and others added some commits May 2, 2019

Migrate to `dataentry_tab` and `dataentry_subtab` from `dataentry_gro…
…up` and `dataentry_subgroup` respectively

- the code compiles.

#5162
Update DataEntryRecordRepository
- Query class uses a recordId instead of TableRecordReference
- Query class has static `of` constructor
- Sort records by updated desc by default

#5162
Update endpoint:
- modify cache key to take into account adLanguage
- make the endpoint generic to search by windowId and recordId instead of only for bpartner and its value

#5162

@metasfresh metasfresh deleted a comment from codacy-bot May 10, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 10, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 10, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 10, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented May 14, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- de.metas.adempiere.adempiere/base/src/main/java/de/metas/dataentry/data/DataEntryRecordRepository.java  1
- de.metas.adempiere.adempiere/base/src/main/java/de/metas/dataentry/data/DataEntryRecord.java  2
         

Complexity decreasing per file
==============================
+ de.metas.business.rest-api/src/main/java/de/metas/bpartner_product/rest/BPartnerProductRestController.java  -1
         

See the complete overview on Codacy

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metasfresh metasfresh deleted a comment from codacy-bot May 14, 2019

@metas-ts metas-ts merged commit 7e8da47 into master May 14, 2019

0 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/jenkins/branch This commit is being built
Details

@metas-ts metas-ts deleted the gh5162 branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.