Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate eMail Text for Notifications #5233 #5270

Merged
merged 30 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@TheBestPessimist
Copy link
Member

commented Jun 3, 2019

@TheBestPessimist TheBestPessimist force-pushed the gh5233 branch 2 times, most recently from fc43b96 to 4094937 Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 5, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 6, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@metasfresh metasfresh deleted a comment from codacy-bot Jun 7, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 1
           

Complexity increasing per file
==============================
- vertical-healthcare_ch/forum_datenaustausch_ch.invoice_base/src/main/java/de/metas/vertical/healthcare_ch/forum_datenaustausch_ch/base/export/invoice/InvoiceImportClientImpl.java  1
- vertical-healthcare_ch/forum_datenaustausch_ch.invoice_440_response/src/main/java/de/metas/vertical/healthcare_ch/forum_datenaustausch_ch/invoice_440/response/Invoice440ToCrossVersionModelTool.java  2
         

See the complete overview on Codacy

private String getEmail(@NonNull final XmlBody body)
{
if (body.getContact().getEmployee() != null)
if (body.getContact().getEmployee().getOnline() != null)

This comment has been minimized.

@@ -82,27 +90,130 @@ private ImportedInvoiceResponse import0(@NonNull final ImportInvoiceResponseRequ
final String xsdName = XmlIntrospectionUtil.extractXsdValueOrNull(inputStreamToUse);
inputStreamToUse.reset();

final CrossVersionResponseConverter converter = crossVersionServiceRegistry.getResponseConverterForXsdName(xsdName);
final CrossVersionResponseConverter converter = crossVersionServiceRegistry.getResponseConverterForXsdName(Objects.requireNonNull(xsdName));

This comment has been minimized.

Copy link
@metas-ts

metas-ts Jun 7, 2019

Member

nice, i wasn't aware of requireNonNull

This comment has been minimized.

Copy link
@metas-ts

metas-ts Jun 7, 2019

Member

on the other hand, i think our own Check.assumeNotNullis better, because you can add an error message, yo a dev can see in the console wtf it is that was null

}

// package visibility
// i believe these 2 methods should be merged into 1 since all that's different is a single TRL.

This comment has been minimized.

Copy link
@metas-ts

metas-ts Jun 7, 2019

Member

so do I

@metas-ts metas-ts merged commit 746abe6 into master Jun 7, 2019

0 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/jenkins/branch This commit is being built
Details

@metas-ts metas-ts deleted the gh5233 branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.