Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show currency in Dunning Type - advanced edit #5369

Merged
merged 4 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@TheBestPessimist
Copy link
Member

commented Jul 8, 2019

TheBestPessimist and others added some commits Jul 8, 2019

Disable caching of `de.metas.dunning.api.impl.DunningDAO.retrieveDunn…
…ings` because sometimes creating dunning types doesn't reset the cache.

metasfresh/metasfresh-e2e#129
5368-app - Show currency in Dunning Type - advanced edit
modernize dunning-code a bit after @TheBestPessimist fixed a caching related bug
* no need caching the "retrieveAll" method. it's usually run only once a day, and we don't have that many C_Dunnings
* caching the getDunningByOrg method instead; might be called very often with the same org
#5368
@codacy-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ de.metas.dunning/src/main/java/de/metas/dunning/api/impl/AbstractDunningDAO.java  -6
         

See the complete overview on Codacy

@metas-ts metas-ts merged commit d7cb523 into master Jul 9, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details

@metas-ts metas-ts deleted the gh5368 branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.