Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPD Shipper and DPD integration #5752

Merged
merged 92 commits into from Nov 14, 2019

Conversation

@TheBestPessimist
Copy link
Member

TheBestPessimist commented Nov 1, 2019

@metasfresh metasfresh deleted a comment Nov 5, 2019
@metasfresh metasfresh deleted a comment Nov 5, 2019
@metasfresh metasfresh deleted a comment Nov 6, 2019
@metasfresh metasfresh deleted a comment Nov 7, 2019
metas-rc and others added 24 commits Oct 7, 2019
Add converter functions for dpd's stupid data style of sending int instead of proper values (or at the very least strings)

Refactor the Soap AuthHeader class

Update the Order and Service types

#5637
@metasfresh metasfresh deleted a comment from metas-ts Nov 12, 2019
@metasfresh metasfresh deleted a comment from metas-ts Nov 13, 2019
@metasfresh metasfresh deleted a comment from metas-ts Nov 14, 2019
@TheBestPessimist TheBestPessimist requested a review from metas-ts Nov 14, 2019
@metasfresh metasfresh deleted a comment from metas-ts Nov 14, 2019
@metas-ts

This comment has been minimized.

Copy link
Member

metas-ts commented Nov 14, 2019

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/DpdShipperGatewayClient.java  6
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/model/DpdServiceType.java  3
- de.metas.shipper.gateway.dpd/src/test/java/de/metas/shipper/gateway/dpd/IntegrationDEtoUSTest.java  1
- de.metas.shipper.gateway.dpd/src/test/java/de/metas/shipper/gateway/dpd/IntegrationDEtoATTest.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/model/DpdPaperFormat.java  3
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/model/DpdOrderCustomDeliveryData.java  3
- de.metas.adempiere.adempiere/base/src/main/java/de/metas/location/impl/CountryCodeFactory.java  2
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/logger/DpdDatabaseClientLogger.java  3
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/logger/DpdClientLogEvent.java  4
- de.metas.shipper.gateway.commons/src/main/java/de/metas/shipper/gateway/commons/ShipperTestHelper.java  2
- de.metas.handlingunits.base/src/main/java/de/metas/handlingunits/inout/impl/HUPackingMaterialDAO.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/util/DpdConversionUtil.java  1
- de.metas.adempiere.adempiere/base/src/main/java/de/metas/location/CountryCode.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/model/DpdClientConfigRepository.java  3
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/util/DpdSoapHeaderWithAuth.java  3
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/DpdDeliveryOrderRepository.java  4
- de.metas.shipper.gateway.dpd/src/test/java/de/metas/shipper/gateway/dpd/DpdTestHelper.java  2
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/model/DpdNotificationChannel.java  3
- de.metas.shipper.gateway.dpd/src/test/java/de/metas/shipper/gateway/dpd/IntegrationDEtoCHTest.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/util/DpdClientUtil.java  1
- de.metas.shipper.gateway.spi/src/main/java/de/metas/mpackage/PackageId.java  3
- de.metas.shipper.gateway.dpd/src/test/java/de/metas/shipper/gateway/dpd/IntegrationDEtoDETest.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/DpdDraftDeliveryOrderCreator.java  3
- de.metas.shipper.gateway.spi/src/main/java/de/metas/shipper/gateway/spi/model/DeliveryOrderLine.java  1
- de.metas.shipper.gateway.dpd/src/main/java/de/metas/shipper/gateway/dpd/DpdShipperGatewayClientFactory.java  1
         

Complexity decreasing per file
==============================
+ de.metas.shipper.gateway.dhl/src/main/java/de/metas/shipper/gateway/dhl/DhlDraftDeliveryOrderCreator.java  -1
         

See the complete overview on Codacy

@metas-ts

This comment has been minimized.

Copy link
Member

metas-ts commented Nov 14, 2019

fine with me to integrate after successful jenkins build

@TheBestPessimist TheBestPessimist merged commit 096d923 into master Nov 14, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details
@TheBestPessimist TheBestPessimist deleted the gh5637 branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.