Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPD Shipper and DPD integration #5791

Merged
merged 7 commits into from Nov 15, 2019
Merged

Add DPD Shipper and DPD integration #5791

merged 7 commits into from Nov 15, 2019

Conversation

@TheBestPessimist
Copy link
Member

TheBestPessimist commented Nov 15, 2019

Dpd Products: Use E12 for same-country and CLASSIC for international shipping

#5637

For some reason, notifications of any kind only work with DpdServiceType classic. All the rest will throw error.
There i no explanation of what's going on, and what combinations are functional.
Because of this all notifications are disabled for now.

#5637
Copy link
Member

metas-ts left a comment

i saw a bunch of commented code and things that say WIP, but i assume it's just like that and you will in fact continue to work at those places, so it's fine with me

@TheBestPessimist

This comment has been minimized.

Copy link
Member Author

TheBestPessimist commented Nov 15, 2019

i saw a bunch of commented code and things that say WIP, but i assume it's just like that and you will in fact continue to work at those places, so it's fine with me

Yes, it's a JUnit test related to DE->US shipping which depends on metasfresh/me03#3157

@TheBestPessimist TheBestPessimist merged commit 4029d92 into master Nov 15, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details
@TheBestPessimist TheBestPessimist deleted the gh5637_2 branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.