Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pricelist Schema export-import #5808

Merged
merged 24 commits into from Nov 25, 2019
Merged

feat: Pricelist Schema export-import #5808

merged 24 commits into from Nov 25, 2019

Conversation

@TheBestPessimist
Copy link
Member

TheBestPessimist commented Nov 21, 2019

@metasfresh metasfresh deleted a comment from metas-ts Nov 22, 2019
@metasfresh metasfresh deleted a comment from metas-ts Nov 22, 2019
@metasfresh metasfresh deleted a comment from metas-ts Nov 22, 2019
@TheBestPessimist TheBestPessimist requested a review from teosarca Nov 22, 2019
Copy link
Member

teosarca left a comment

see my comments

BPartnerId getBPartnerIdByValue(String bpartnerValue);

@Nullable
BPartnerId getBPartnerIdByValueOrNull(String valueFixed);

This comment has been minimized.

Copy link
@teosarca

teosarca Nov 22, 2019

Member

param name is notice
return optional
call method ....IfExists


final PricingConditionsId pricingConditionsId = PricingConditionsId.ofDiscountSchemaId(discountSchemaRecordId);
final PricingConditionsId pricingConditionsId = PricingConditionsId.ofRepoId(discountSchemaRecordId);

This comment has been minimized.

Copy link
@teosarca

teosarca Nov 22, 2019

Member

this is pointless...

This comment has been minimized.

Copy link
@TheBestPessimist

TheBestPessimist Nov 25, 2019

Author Member

It's not. I had to change to ofRepoId from ofDiscountSchemaId because otherwise a repoIdAware test was failing. (it was searching via reflection for ofRepoId

@TheBestPessimist TheBestPessimist changed the title feat: Pricelist Schema export-import feat: Pricelist Schema export-import Nov 25, 2019
@TheBestPessimist TheBestPessimist merged commit c4760d0 into master Nov 25, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details
@TheBestPessimist TheBestPessimist deleted the gh5799 branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.