Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricelist Schema export-import #5817

Merged
merged 3 commits into from Nov 25, 2019
Merged

Pricelist Schema export-import #5817

merged 3 commits into from Nov 25, 2019

Conversation

@TheBestPessimist
Copy link
Member

TheBestPessimist commented Nov 25, 2019

Fixes after review
#5799

Copy link
Member

metas-ts left a comment

Note about Optional<BPartnerId> getBPartnerIdByValue(@NonNull final String value):

  • We don't make sure that C_BPartner.Value is unique, but that seems to be a long-standing problem. Note to self: I think I'm going to deprecate the method and ask devs to use the method with BPArtnerquery (=> contains also org)
@TheBestPessimist TheBestPessimist merged commit e5c70d8 into master Nov 25, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details
@TheBestPessimist TheBestPessimist deleted the gh5799_2 branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.