Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery contract with same product but different attributes #5826

Closed
wants to merge 2 commits into from

Conversation

@TheBestPessimist
Copy link
Member

TheBestPessimist commented Nov 26, 2019

@metas-ts

This comment has been minimized.

Copy link
Member

metas-ts commented Nov 26, 2019

closing the PR without integration:

  • 1e38fc0: there won't be a (e2e-)test for the changes in some time, and we can't rule out that the code change e.g. introduces NPEs or other glitches

  • 3cefa39: as i wrote

Can the customer freely pick the PMM_Product.ProductName ?

  • if yes => remove ASI_ID from Identifiercolumns
  • if no => remove ASI_ID from Identifiercolumns and add SeqNo isntead

..productname is read-only, and set in de.metas.procurement.base.impl.PMMProductNameBuilder), so i don'T see a benefit in adding SeqNo

@metas-ts metas-ts closed this Nov 26, 2019
@metas-ts metas-ts deleted the gh5823 branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.