Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160 Can now download in excel shipment dispositions past their due date. #5958

Merged
merged 5 commits into from Dec 20, 2019

Conversation

@dragospodariu96
Copy link
Contributor

dragospodariu96 commented Dec 20, 2019

No description provided.

Copy link
Member

metas-ts left a comment

@dragospodariu96
as talked: will integrated and 🍒pick and i think it will make the user happy.
but please after the x-mas-break, do the following which I only thought of after our talk:

  • also add sps.IsActive='Y' to the where-clause. Because sometimes we deactivate record just to have them out of the way. Those should not show up in your excel
  • add another parameter p_AD_Org_ID. Shipment schedules are per-org. And in case of a multi-org user, we don't want different orgs' records to be mixed up.
    • so please add sps.AD_Org_ID=p_AD_Org_ID to the where-clause, make the org-parameter mandatory in the process and preset it with @#AD_Org_ID/0@ (that's the org-id of the current user, note the #)
  • now that we are adding a param, please rename the two existing ones...our convention is to prepend p_. And the bpartner-one should be p_C_BPartner_ID (as opposed to p_M_BPartner_ID)
@metas-ts metas-ts merged commit a7b58e4 into master Dec 20, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/jenkins/branch This commit looks good
Details
@metas-ts metas-ts deleted the gh160 branch Dec 20, 2019
metas-ts added a commit that referenced this pull request Dec 20, 2019
* #160 Can now download in excel shipment dispositions past their due date.

* #160 Displaying columns with the right translations now.

* #160 Translated WebUI Action for all languages.

* #160 Fixed encoding.

* #160 Translated excel columns for German UI.

(cherry picked from commit a7b58e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.