Fixes arity problem introduced by rails 3.2.5 #1

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@dball

dball commented Jun 11, 2012

Rails 3.2.5 changed the arity of a method you're alias_method_chaining. This patch corrects that. Sadly, this doesn't seem to be exercised by the test suite anywhere, but I can verify it was broken, and now works, when integrated with a real-world app. :)

@metaskills

This comment has been minimized.

Show comment
Hide comment
@metaskills

metaskills Jun 12, 2012

Owner

So odd, the test suite does exercise that method because if you comment out the guts, one fails. Odd. I've pushed v3.2.0 with this. Thanks.

Owner

metaskills commented Jun 12, 2012

So odd, the test suite does exercise that method because if you comment out the guts, one fails. Odd. I've pushed v3.2.0 with this. Thanks.

@metaskills metaskills reopened this Jun 12, 2012

@metaskills

This comment has been minimized.

Show comment
Hide comment
@metaskills

metaskills Jun 13, 2012

Owner

Had to be persnickety and make the arg name match. No need to upgrade, but 3.2.1 is out.

Owner

metaskills commented Jun 13, 2012

Had to be persnickety and make the arg name match. No need to upgrade, but 3.2.1 is out.

@metaskills metaskills closed this Jun 13, 2012

@dball

This comment has been minimized.

Show comment
Hide comment
@dball

dball Jun 13, 2012

Our future selves appreciate your careful attention to detail; names are important. Thanks!

dball commented Jun 13, 2012

Our future selves appreciate your careful attention to detail; names are important. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment