New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset summary is wrong in add dataset popup #1121

Closed
paigechoi opened this Issue Dec 19, 2018 · 0 comments

Comments

Projects
None yet
4 participants
@paigechoi
Copy link
Contributor

paigechoi commented Dec 19, 2018

Describe the bug
Dataset information (summary) is wrong in add dataset popup

To Reproduce
Steps to reproduce the behavior:
Dataflow detail -> click add dataset -> click one dataset -> see error in summary area (on your right)

Expected behavior
Dataset information should be shown (Rows and size)

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Will fix this issue in this branch too
image

paigechoi added a commit that referenced this issue Dec 19, 2018

@paigechoi paigechoi referenced this issue Jan 11, 2019

Merged

F#1121 wrong dataset summary #1241

2 of 9 tasks complete

@sang-hee-lee sang-hee-lee added this to the 3.2.0 milestone Jan 15, 2019

joohokim1 added a commit that referenced this issue Jan 15, 2019

F#1121 wrong dataset summary (#1241)
* #1121 Fix different dataset (db) UI

* #1121 Delete size when dataset is DB type, send request until total Lines is not -1

* #1121 Delete unnecessary code (Refactoring)

@joohokim1 joohokim1 closed this Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment