Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window rule column generation order #1380

Closed
joohokim1 opened this issue Feb 1, 2019 · 1 comment
Closed

window rule column generation order #1380

joohokim1 opened this issue Feb 1, 2019 · 1 comment
Assignees
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Milestone

Comments

@joohokim1
Copy link
Contributor

joohokim1 commented Feb 1, 2019

Describe the bug
The preceeding expression goes latter.

To Reproduce
Steps to reproduce the behavior:

  1. Import finefood.sample.txt "with colon delimiter."
  2. Click the generated I.DS.
  3. Click Create dataflow with this dataset.
  4. Edit rules.
  5. Drop column3 and all after.
  6. Select window command.
  7. Input 3 expressions - lead(column1, 0), lead(column1, 1), lead(column1, 2)
  8. Click Done.
  9. The new columns order is the result of lead(column1, 2), lead(column1, 1), lead(column1, 0)

Expected behavior
The order of the expressions the user entered would be better.

Screenshots
2019-01-31 12 35 30

Additional context
There is a logic that a new column comes right after the target column. (if any)
But, in this case, all the expressions should be appended in series.

@joohokim1 joohokim1 added bug Something isn't working @dataprep Component Name : Data preparation labels Feb 1, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Feb 1, 2019
@joohokim1 joohokim1 self-assigned this Feb 1, 2019
@joohokim1
Copy link
Contributor Author

1st integrated test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dataprep Component Name : Data preparation
Projects
None yet
Development

No branches or pull requests

2 participants