Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize selection value when selecting notebook server in workspace #2170

Closed
AnnieHwang opened this issue May 31, 2019 · 6 comments

Comments

@AnnieHwang
Copy link
Contributor

commented May 31, 2019

Describe the bug
Initialize selection value when selecting notebook server in workspace
워크스페이스 내의 노트북 서버 선택 시 라디오버튼의 선택 해제 기능이 없어 버그가 발생됨

To Reproduce
Steps to reproduce the behavior:
Workspace > More button > Set Notebook Server > Selection

Expected behavior
마지막 라디오버튼을 선택한 값이 있으면 이전 라디오버튼 선택된 값이 선택되지 말아야 함(아무리 탭이 나눠져 있더라도..)

아래의 동영상에서 마지막에 Jupyter의 'jupyter-default'를 선택하면, 이전 선택 값인 Zeppelin의 'Zeppelin Dev'은 선택이 되지 말아야 함 => 그래야 결론적으로 하나의 선택값으로 저장이 가능함

Screenshots
image
2019-05-31_18-24-13

@kyungtaak

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@AnnieHwang I think you should consider the function definition. Why should only one laptop server be available?

@AnnieHwang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@kyungtaak Both Zeppelin and Jupyter can be selected ,which is what i want. I thought It is so difficult to develop to select both. If Zeppelin and Jupyter can be selected both, it should work like now (but without errors).

@AnnieHwang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

오늘 회의 결과를 정리하면 아래와 같습니다. 해당 내용으로 추가 기획 진행하도록 하겠습니다.

  • 노트북 서버는 종류별로 각각 1개씩 고를수 있음 (Jupyter 1개, Zeppelin 1개)
  • Deselection 기능은 추가하는게 좋을 것 같음
@AnnieHwang

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@koeun222 라디오박스 상단에 Deselection 버튼 디자인 부탁드려요 (해당 부분은 필터 위젯 - 라디오 형과 동일한 UI이면 될것 같아요)
image

@koeun222

This comment has been minimized.

Copy link

commented Jun 20, 2019

@AnnieHwang "deselect" 버튼 추가했습니다-
image

@kyungtaak kyungtaak assigned minhyun2 and unassigned kyungtaak Jul 7, 2019

minhyun2 added a commit that referenced this issue Jul 17, 2019

alchan-lee added a commit that referenced this issue Jul 22, 2019

#2240 Change to url mode when creating notebook server (#2346)
* #2240 change to url mode when creating notebook server

* #2240 add url validation

* #2240 change notebook server validation ui

* #2240 fix url validation check logic

* #2170 deselect notebook server

* #2240 Improve notebook exception handling and change label

* #2240 improve notebook server list ui

* #2240 improve set notebook server ui

@alchan-lee alchan-lee closed this Jul 22, 2019

@minhyun2

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

image

Changed to select (None) at the top of list instead of 'Deselect' button
(초기화를 위한 Deselect 버튼 대신에 리스트 최상단에 (None) 을 선택하도록 변경되었습니다.)

alchan-lee added a commit that referenced this issue Jul 25, 2019

#2240 Change to url mode when creating notebook server (#2346)
* #2240 change to url mode when creating notebook server

* #2240 add url validation

* #2240 change notebook server validation ui

* #2240 fix url validation check logic

* #2170 deselect notebook server

* #2240 Improve notebook exception handling and change label

* #2240 improve notebook server list ui

* #2240 improve set notebook server ui

ufoscw added a commit that referenced this issue Jul 29, 2019

#2240 Change to url mode when creating notebook server (#2346)
* #2240 change to url mode when creating notebook server

* #2240 add url validation

* #2240 change notebook server validation ui

* #2240 fix url validation check logic

* #2170 deselect notebook server

* #2240 Improve notebook exception handling and change label

* #2240 improve notebook server list ui

* #2240 improve set notebook server ui

ufoscw added a commit that referenced this issue Jul 29, 2019

#2240 Change to url mode when creating notebook server (#2346)
* #2240 change to url mode when creating notebook server

* #2240 add url validation

* #2240 change notebook server validation ui

* #2240 fix url validation check logic

* #2170 deselect notebook server

* #2240 Improve notebook exception handling and change label

* #2240 improve notebook server list ui

* #2240 improve set notebook server ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.