New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create dataset button in dataset swap popup #932

Closed
paigechoi opened this Issue Nov 28, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@paigechoi
Copy link
Contributor

paigechoi commented Nov 28, 2018

Describe the bug
Create dataset button is missing is dataset swapping popup

To Reproduce
Go to dataflow detail -> click one imported datset icon -> click dataset swap -> see error

Expected behavior
See screen shot

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@paigechoi paigechoi added the bug label Nov 28, 2018

@paigechoi paigechoi added this to the 3.1.0 milestone Nov 28, 2018

@paigechoi paigechoi added the @dataprep label Nov 28, 2018

@paigechoi paigechoi removed this from the 3.1.0 milestone Nov 30, 2018

@joohokim1 joohokim1 added this to the 3.2.0 milestone Jan 7, 2019

@paigechoi paigechoi assigned imsaaks and unassigned paigechoi Jan 7, 2019

imsaaks added a commit that referenced this issue Jan 9, 2019

imsaaks added a commit that referenced this issue Jan 9, 2019

imsaaks added a commit that referenced this issue Jan 9, 2019

@imsaaks

This comment has been minimized.

Copy link
Contributor

imsaaks commented Jan 10, 2019

The add dataset screen, which runs on the Dataflow detail screen, has been changed.
'Create dataset' button has been added at the bottom of the 'add dataset', 'swap dataset' pop-up screen.

@imsaaks imsaaks referenced this issue Jan 10, 2019

Merged

F#932 add create dataset in swap popup #1226

0 of 8 tasks complete

joohokim1 added a commit that referenced this issue Jan 10, 2019

F#932 add create dataset in swap popup (#1226)
* #932 add create dataset button (add/swap popup)

* #932 delete unnecessary code

* #932 replace popup title

* #932 reset scroll position after dataset creation

* #932 send dsId after dataset creation is complete

@joohokim1 joohokim1 closed this Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment