Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix column dictionary's name duplicate check #2296

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@ufoscw
Copy link
Contributor

commented Jul 2, 2019

Description

fix column dictionary's name duplicate check

Related Issue :

How Has This Been Tested?

  1. create column dictionary (name : abc, recommended name : qwe)
  2. change name "abc" to "qwe"
  3. click check button for duplicate check
  4. Confirms that there are no errors

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@ufoscw ufoscw added the @metadata label Jul 2, 2019

@ufoscw ufoscw requested review from kyungtaak, alchan-lee and minhyun2 Jul 2, 2019

@ufoscw ufoscw added the testbed2 label Jul 2, 2019

@ufoscw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

run build
deploy to 2

@AnnieHwang

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@ufoscw After the new dictionary is created, it is not at the top of the list. Currently, sorting is not possible, but the default sorting should be in the order in which they were created. Please, check it.

@ufoscw ufoscw merged commit 58c9e13 into master Jul 2, 2019

2 checks passed

CodeFactor No issues found.
Details
Metatron CI
Details
@ufoscw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@AnnieHwang
ok.
I will create a new issue and process it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.