-
Notifications
You must be signed in to change notification settings - Fork 14
fix: only build xtask once for the tests #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent updates encompass platform migration, configuration adjustments, and script modifications. The platform for the lock file has transitioned from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
Do the same for meta-cli as well? Each test file "builds" it once with the current scheme. |
|
Also, eliminate the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 73.60% 73.58% -0.03%
==========================================
Files 121 121
Lines 14187 14174 -13
Branches 1416 1415 -1
==========================================
- Hits 10443 10430 -13
Misses 3717 3717
Partials 27 27 ☔ View full report in Codecov by Sentry. |
zifeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! @Yohe-Am's suggestion is great also, wanna tackle here or next?
de72f89 to
a4e706f
Compare
a4e706f to
41e2ab5
Compare
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
# Conflicts: # dev/Dockerfile # dev/lock.yml # rust-toolchain.toml
Use the xtask binary to run the tests.
Summary by CodeRabbit
New Features
x86_64-linux.Improvements
These changes improve platform compatibility and streamline the testing process.