fix(release): Fix fat CLI compilation #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natoandro
requested review from
Yohe-Am,
destifo,
michael-0acf4 and
zifeo
and removed request for
Yohe-Am
michael-0acf4
previously approved these changes
May 20, 2024
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 74.05% 73.52% -0.53%
==========================================
Files 120 120
Lines 13777 14142 +365
Branches 1407 1416 +9
==========================================
+ Hits 10202 10398 +196
- Misses 3549 3717 +168
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
So the tests took 30 minutes with each file taking an avg of 30 seconds. Not entirely sure why python_test is taking that long. |
destifo
reviewed
May 22, 2024
Signed-off-by: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fat CLI compilation
Bump to 0.4.2
Bump wasmtime to 21
Bump rust to 1.78.0
The change comes with new or modified tests
Hard-to-understand functions have explanatory comments
End-user documentation is updated to reflect the change