-
Notifications
You must be signed in to change notification settings - Fork 15
chore(docs): replace term materializer with function for user facing concepts #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): replace term materializer with function for user facing concepts #736
Conversation
|
@coderabbitai review |
WalkthroughThe overall change involves updating terminology from "materializers" to "functions" across various Python, TypeScript, and documentation files. This semantic shift aims to clarify the role of these entities in transforming inputs to outputs, reflecting their true purpose in the system. The changes affect comments, documentation, and code descriptions to ensure consistency and clarity in the terminology used throughout the project. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 73.00% 73.00%
=======================================
Files 117 117
Lines 14171 14171
Branches 1414 1415 +1
=======================================
Hits 10345 10345
Misses 3799 3799
Partials 27 27 ☔ View full report in Codecov by Sentry. |
zifeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we may miss some rephrasing but that's good enough for now
I tried to fix/remove a few things but I guess that's expected since most had the materializer concept in mind, functions was rather used to refer the node/type. |
destifo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder though what this means to the abbreviation "MDK"
We should keep that, I think we can define materializer in the MDK section instead as it would actually mean something concrete to the user there. |
Materializer and function might introduce confusion as they are pretty much the same thing from the user point of view, one can be defined in terms of the other.
Migration notes
None
Summary by CodeRabbit
These changes enhance the readability and consistency of our documentation, making it easier for users to understand and implement the features and concepts within the system.