Conversation
Yohe-Am
left a comment
There was a problem hiding this comment.
Sorry for another large PR ya'll. Didn't know how I could break this down.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 72.99% 73.10% +0.11%
==========================================
Files 117 116 -1
Lines 14181 14137 -44
Branches 1414 1417 +3
==========================================
- Hits 10351 10335 -16
+ Misses 3803 3775 -28
Partials 27 27 ☔ View full report in Codecov by Sentry. |
zifeo
left a comment
There was a problem hiding this comment.
Looks good, should the swc dependencies also be removed and also the post processing inside the typegate?
|
Another usecase was unfortunately discovered for the typescript crates here. To compile user provided typescript modules to javascript. (Deno also makes use of Note, these crates are no longer built by the thin cli. |
|
Yeah, that what I meant by the post processing on the type gate side, I believe there is no usage anymore: metatype/typegate/src/postprocess.ts Line 4 in 8dde1fa |
a1701be to
a4c32ad
Compare
mdk_typescriptcode generator for typescript type inference on Deno runtime external modules.Migration notes
metatype.yamlhas changed. Targets are now lists instead of maps, items no sportinggeneratorfield instead of key acting as ref to generator.fromExportmethod has been renamed toexportto make it more uniform to handler.exportandhandlermethod's now expect handler/func name undernameinstead offunc.codegenflag has been removed fromArtifactsConfigobject.gen mod/mdkhas been simplified to justgenas the previous mod option is no longer avail.