fix: upload url path and add logging in the SDK#740
Merged
Conversation
Yohe-Am
previously approved these changes
Jun 11, 2024
Contributor
Yohe-Am
left a comment
There was a problem hiding this comment.
Heroic work. Will hopefully be the last major refactor this quarter lol
Contributor
michael-0acf4
left a comment
There was a problem hiding this comment.
I guess reverting back to stdout but with a better protocol on top is also worth trying considering the server approach had some overhead and rise in maintenance difficulty. 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 73.06% 73.43% +0.37%
==========================================
Files 116 115 -1
Lines 14150 14022 -128
Branches 1417 1416 -1
==========================================
- Hits 10338 10297 -41
+ Misses 3786 3699 -87
Partials 26 26 ☔ View full report in Codecov by Sentry. |
zifeo
reviewed
Jun 17, 2024
Natoandro
commented
Jun 17, 2024
Yohe-Am
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration notes
The
typegraphs.denosection of themetatype.yamlconfig file has been replaced bytypegraphs.typescriptandtypegraphs.javascript.tg_deployparams has changed.The change comes with new or modified tests
Hard-to-understand functions have explanatory comments
End-user documentation is updated to reflect the change