Skip to content

fix: upload url path and add logging in the SDK#740

Merged
Natoandro merged 38 commits into
mainfrom
deployment
Jun 18, 2024
Merged

fix: upload url path and add logging in the SDK#740
Natoandro merged 38 commits into
mainfrom
deployment

Conversation

@Natoandro
Copy link
Copy Markdown
Contributor

@Natoandro Natoandro commented May 30, 2024

  • Fix upload url: prepare-upload returns upload tokens instead of upload urls
  • Add logging in the typegraph SDK
  • Refactor the actor system in the CLI
  • Use jsonrpc for communication between the CLI and typegraph processes (over stdin/stdout)

Migration notes

  • The typegraphs.deno section of the metatype.yaml config file has been replaced by typegraphs.typescript and typegraphs.javascript.

  • tg_deploy params has changed.

  • The change comes with new or modified tests

  • Hard-to-understand functions have explanatory comments

  • End-user documentation is updated to reflect the change

@Natoandro Natoandro marked this pull request as ready for review June 11, 2024 08:26
@Natoandro Natoandro requested review from Yohe-Am, destifo, michael-0acf4 and zifeo and removed request for destifo and michael-0acf4 June 11, 2024 08:26
Yohe-Am
Yohe-Am previously approved these changes Jun 11, 2024
Copy link
Copy Markdown
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroic work. Will hopefully be the last major refactor this quarter lol

Comment thread meta-cli/src/deploy/actors/task/command/typescript.rs
Comment thread typegraph/node/sdk/src/io.ts
Copy link
Copy Markdown
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess reverting back to stdout but with a better protocol on top is also worth trying considering the server approach had some overhead and rise in maintenance difficulty. 👍

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 40.54054% with 132 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (9ed105d) to head (11400dd).
Report is 1 commits behind head on main.

Files Patch % Lines
typegate/src/runtimes/python.ts 0.00% 99 Missing ⚠️
typegate/src/services/artifact_service.ts 61.53% 10 Missing ⚠️
typegate/src/typegate/artifacts/local.ts 41.66% 7 Missing ⚠️
typegate/src/typegate/artifacts/mod.ts 57.14% 6 Missing ⚠️
...pegate/src/runtimes/prisma/hooks/run_migrations.ts 76.47% 4 Missing ⚠️
typegate/src/services/responses.ts 42.85% 4 Missing ⚠️
typegate/src/typegate/mod.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   73.06%   73.43%   +0.37%     
==========================================
  Files         116      115       -1     
  Lines       14150    14022     -128     
  Branches     1417     1416       -1     
==========================================
- Hits        10338    10297      -41     
+ Misses       3786     3699      -87     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

Comment thread libs/metagen/metatype.yaml
Comment thread meta-cli/src/com/store.rs Outdated
Comment thread meta-cli/src/deploy/actors/task.rs Outdated
Comment thread typegate/tests/metagen/__snapshots__/metagen_test.ts.snap
@Natoandro Natoandro merged commit 509b61b into main Jun 18, 2024
@Natoandro Natoandro deleted the deployment branch June 18, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants