Skip to content

feat(docs): add embedded typegate page#747

Merged
zifeo merged 4 commits into
mainfrom
docs/embedded-typegate
Jun 3, 2024
Merged

feat(docs): add embedded typegate page#747
zifeo merged 4 commits into
mainfrom
docs/embedded-typegate

Conversation

@destifo
Copy link
Copy Markdown
Contributor

@destifo destifo commented Jun 2, 2024

Embedded typegate docs page

  • need a page under meta-cli/embedded typegate to explain how that works
  • tutorials should take advantage of the embedded one
  • the embedded one should be the default everything
  • explain that there is 2 flavors in reference/meta-cli

MET-562

Migration notes

No Migrations Needed
...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@destifo destifo self-assigned this Jun 2, 2024
@destifo destifo marked this pull request as ready for review June 2, 2024 15:11
Comment thread website/shared/meta-cli/embedded-typegate.mdx Outdated
Comment thread website/shared/meta-cli/embedded-typegate.mdx Outdated
Comment thread website/shared/meta-cli/embedded-typegate.mdx Outdated
Comment thread website/shared/meta-cli/embedded-typegate.mdx
Comment thread website/shared/projects/tab-first-project-python.mdx Outdated
Comment thread website/shared/projects/tab-first-project-python.mdx Outdated
@zifeo
Copy link
Copy Markdown
Member

zifeo commented Jun 2, 2024

Nice improvements! A few phrasing suggestions :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (544206c) to head (c701c0c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   73.00%   73.00%           
=======================================
  Files         117      117           
  Lines       14171    14171           
  Branches     1415     1415           
=======================================
  Hits        10345    10345           
  Misses       3799     3799           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@destifo destifo requested a review from zifeo June 3, 2024 17:04
Copy link
Copy Markdown
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rewordings!

@zifeo zifeo merged commit 8dde1fa into main Jun 3, 2024
@zifeo zifeo deleted the docs/embedded-typegate branch June 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants