-
Notifications
You must be signed in to change notification settings - Fork 14
refactor(sdk)!: back to deno + jsr exploration #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: afmika <afmichael73@gmail.com>
b674b84 to
a73bb1d
Compare
Yohe-Am
previously approved these changes
Jun 21, 2024
Yohe-Am
previously approved these changes
Jun 24, 2024
7afe45b to
6771f6b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 73.49% 70.09% -3.40%
==========================================
Files 117 137 +20
Lines 14195 16060 +1865
Branches 1421 1466 +45
==========================================
+ Hits 10432 11257 +825
- Misses 3738 4778 +1040
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Yohe-Am
reviewed
Jun 28, 2024
Yohe-Am
reviewed
Jun 29, 2024
Yohe-Am
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try reverting back to deno runtime for the typescript sdk in hope of making the dx easier.
Hosting a custom node/npm project adds more layer of indirection which may result in cryptic issues sometimes.
This should also facilitate publishing on jsr although additional work are still required on the
jcocodegen side.Migration notes
N/A