Skip to content

Conversation

@michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Jun 19, 2024

Try reverting back to deno runtime for the typescript sdk in hope of making the dx easier.
Hosting a custom node/npm project adds more layer of indirection which may result in cryptic issues sometimes.

This should also facilitate publishing on jsr although additional work are still required on the jco codegen side.

Migration notes

N/A

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@michael-0acf4 michael-0acf4 marked this pull request as draft June 19, 2024 15:59
@michael-0acf4 michael-0acf4 marked this pull request as ready for review June 21, 2024 15:17
Yohe-Am
Yohe-Am previously approved these changes Jun 21, 2024
Yohe-Am
Yohe-Am previously approved these changes Jun 24, 2024
@codecov
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 66.83673% with 65 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (251f128) to head (15efe9f).
Report is 1 commits behind head on main.

Files Patch % Lines
typegraph/deno/sdk/src/types.ts 33.33% 24 Missing ⚠️
typegraph/deno/sdk/src/runtimes/deno.ts 61.11% 14 Missing ⚠️
typegraph/deno/sdk/src/host/host.js 7.14% 13 Missing ⚠️
typegraph/deno/sdk/src/utils/injection_utils.ts 30.00% 7 Missing ⚠️
typegraph/deno/sdk/src/deps/mod.ts 33.33% 4 Missing ⚠️
typegraph/deno/sdk/src/typegraph.ts 85.71% 2 Missing ⚠️
typegraph/deno/sdk/src/policy.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   73.49%   70.09%   -3.40%     
==========================================
  Files         117      137      +20     
  Lines       14195    16060    +1865     
  Branches     1421     1466      +45     
==========================================
+ Hits        10432    11257     +825     
- Misses       3738     4778    +1040     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-0acf4 michael-0acf4 requested a review from Yohe-Am June 27, 2024 19:14
@michael-0acf4 michael-0acf4 merged commit 2e98f8d into main Jun 29, 2024
@michael-0acf4 michael-0acf4 deleted the back-to-deno branch June 29, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants