feat: kv runtime #797
Merged
feat: kv runtime #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=======================================
Coverage ? 69.40%
=======================================
Files ? 143
Lines ? 16598
Branches ? 1478
=======================================
Hits ? 11520
Misses ? 5052
Partials ? 26 ☔ View full report in Codecov by Sentry. |
zifeo
reviewed
Jul 23, 2024
Natoandro
requested changes
Jul 23, 2024
j03-dev
force-pushed
the
feat/met-601-kv-runtime
branch
from
14d7f1f to
5ba146d
Compare
Member
|
Looks good, definitely missing tests though :) |
zifeo
reviewed
Jul 30, 2024
j03-dev
force-pushed
the
feat/met-601-kv-runtime
branch
2 times, most recently
from
4ba2191 to
6f4b117
Compare
Natoandro
requested changes
Aug 6, 2024
Contributor
Natoandro
left a comment
Natoandro
left a comment
There was a problem hiding this comment.
Can you update the docs?
j03-dev
force-pushed
the
feat/met-601-kv-runtime
branch
2 times, most recently
from
a7d4143 to
67f2083
Compare
zifeo
previously approved these changes
Aug 7, 2024
michael-0acf4
previously approved these changes
Aug 8, 2024
j03-dev
dismissed stale reviews from michael-0acf4, Natoandro, and zifeo
via
79b45cb
j03-dev
force-pushed
the
feat/met-601-kv-runtime
branch
from
67f2083 to
79b45cb
Compare
Natoandro
reviewed
Aug 9, 2024
values, list all values from redis
j03-dev
force-pushed
the
feat/met-601-kv-runtime
branch
from
ecf5c8a to
b21a0da
Compare
zifeo
previously approved these changes
Aug 12, 2024
zifeo
previously approved these changes
Aug 12, 2024
zifeo
previously approved these changes
Aug 12, 2024
zifeo
previously approved these changes
Aug 12, 2024
michael-0acf4
approved these changes
Aug 13, 2024
Natoandro
reviewed
Aug 13, 2024
| } | ||
|
|
||
| #operation(operation: KvMaterializer, effect: Effect) { | ||
| const mad_id = runtimes.kvOperation({ |
Contributor
There was a problem hiding this comment.
Looks like someone's mad 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration notes
...