feat: better arg split logic for MCLI_LOADER#799
Merged
Conversation
Contributor
michael-0acf4
left a comment
michael-0acf4
left a comment
There was a problem hiding this comment.
Looking good so far, just make sure you find all places where a naive .split(' ') is used on meta cli, the ones I provided was for reference.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
=======================================
Coverage 69.91% 69.91%
=======================================
Files 139 139
Lines 16181 16181
Branches 1475 1476 +1
=======================================
Hits 11313 11313
Misses 4843 4843
Partials 25 25 ☔ View full report in Codecov by Sentry. |
michael-0acf4
requested changes
Jul 24, 2024
michael-0acf4
approved these changes
Jul 25, 2024
Yohe-Am
added a commit
that referenced
this pull request
Aug 7, 2024
commit 25d96a8 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Wed Aug 7 07:21:33 2024 +0300 refactor: PreparedArgs api commit 278bc09 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Wed Aug 7 03:10:16 2024 +0300 test: alias tests commit 8ff17ec Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Fri Aug 2 08:46:56 2024 +0300 fix: test commit 62d534d Merge: d1c532e 4c30067 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Fri Aug 2 06:46:33 2024 +0300 Merge branch 'main' into feat/MET-567/python-gen-client commit d1c532e Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Fri Aug 2 04:30:28 2024 +0300 tests: client_py commit 676bdb8 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Fri Aug 2 03:58:03 2024 +0300 tests: client_py commit 4c30067 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Thu Aug 1 11:36:14 2024 +0300 chore: prepare 0.4.6 (#795) - Bump version to 0.4.6-0 - Add sanity tests for published SDKs - Bump deno to 1.45.2 - Bump rust to 1.79.0 - Fix myriad of bugs #### Migration notes ... - [x] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced new logging capabilities in the `ConnectedEngine` with adjustable logging levels. - Implemented cleanup procedures in tests to enhance resource management. - **Bug Fixes** - Fixed import paths for permissions to ensure correct functionality in tests and applications. - **Version Updates** - Incremented version numbers across multiple projects and packages to reflect ongoing development and improvements. - **Documentation** - Added comments to clarify code behavior and potential future considerations in various modules. - **Refactor** - Optimized string handling in several functions and adjusted method signatures for improved clarity and efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> commit f0ecfb5 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Thu Aug 1 08:01:10 2024 +0300 wip: wip commit a48203a Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Thu Aug 1 06:15:12 2024 +0300 wip: wip commit bfee2f2 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Thu Aug 1 05:22:51 2024 +0300 wip: wip commit e57c322 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Wed Jul 31 19:16:23 2024 +0300 wip: wip commit f55a3e7 Author: Yohe-Am <56622350+Yohe-Am@users.noreply.github.com> Date: Wed Jul 31 13:37:01 2024 +0300 wip: wip commit 25d5c24 Author: FITAHIANA Nomeniavo joe <24nomeniavo@gmail.com> Date: Thu Jul 25 20:59:22 2024 +0300 feat: better arg split logic for MCLI_LOADER (#799) <!-- Pull requests are squashed and merged using: - their title as the commit message - their description as the commit body Having a good title and description is important for the users to get readable changelog. --> <!-- 1. Explain WHAT the change is about --> - <!-- 2. Explain WHY the change cannot be made simpler --> - <!-- 3. Explain HOW users should update their code --> #### Migration notes ... - [ ] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration notes
...