Skip to content

Conversation

@michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Aug 9, 2024

User side of substantial

Migration notes

None

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@linear
Copy link

linear bot commented Aug 9, 2024

@michael-0acf4 michael-0acf4 force-pushed the met-623-subs-sdk-gate-sdk-and-typing branch from 00bb01b to 864b51f Compare August 9, 2024 16:55
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and simple. Missing tests though.

@michael-0acf4
Copy link
Contributor Author

Looking good and simple. Missing tests though.

Right, but at this point it's just user side code, there is really nothing to test against it. Raw serialize is an idea though..

@michael-0acf4 michael-0acf4 requested a review from Yohe-Am August 16, 2024 10:23
@michael-0acf4 michael-0acf4 merged commit 58d220f into main Aug 18, 2024
@michael-0acf4 michael-0acf4 deleted the met-623-subs-sdk-gate-sdk-and-typing branch August 18, 2024 05:11
@codecov
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 69 lines in your changes missing coverage. Please review.

Project coverage is 69.12%. Comparing base (54da279) to head (b4e5f34).
Report is 3 commits behind head on main.

Files Patch % Lines
typegraph/deno/sdk/src/runtimes/substantial.ts 7.81% 59 Missing ⚠️
typegraph/deno/sdk/src/runtimes/python.ts 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   69.40%   69.12%   -0.28%     
==========================================
  Files         143      144       +1     
  Lines       16598    16673      +75     
  Branches     1477     1478       +1     
==========================================
+ Hits        11520    11526       +6     
- Misses       5052     5121      +69     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants