-
Notifications
You must be signed in to change notification settings - Fork 14
feat(sub): sdk and typing #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00bb01b to
864b51f
Compare
Yohe-Am
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and simple. Missing tests though.
Right, but at this point it's just user side code, there is really nothing to test against it. Raw serialize is an idea though.. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 69.40% 69.12% -0.28%
==========================================
Files 143 144 +1
Lines 16598 16673 +75
Branches 1477 1478 +1
==========================================
+ Hits 11520 11526 +6
- Misses 5052 5121 +69
Partials 26 26 ☔ View full report in Codecov by Sentry. |
User side of substantial
Migration notes
None