refactor: flatten deps and improve repo folder#821
Merged
Conversation
Yohe-Am
commented
Aug 26, 2024
Contributor
Author
Yohe-Am
left a comment
Yohe-Am
left a comment
There was a problem hiding this comment.
This PR is best viewed inside the vscode github pr extension.
3 tasks
Yohe-Am
commented
Aug 26, 2024
Contributor
Author
Yohe-Am
left a comment
Yohe-Am
left a comment
There was a problem hiding this comment.
This is 99% renames actually.
…on docs (#822) <!-- Pull requests are squashed and merged using: - their title as the commit message - their description as the commit body Having a good title and description is important for the users to get readable changelog. --> <!-- 1. Explain WHAT the change is about --> - [x] add a warning that envs are not set. <!-- 2. Explain WHY the change cannot be made simpler --> [MET-635](https://linear.app/metatypedev/issue/MET-635/cli-ensure-documentation-is-pushing-for-meta-dev-instead-of-meta) <!-- 3. Explain HOW users should update their code --> _No Migration Needed_ - [ ] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 69.05% 75.95% +6.90%
==========================================
Files 144 144
Lines 16704 16696 -8
Branches 1481 1639 +158
==========================================
+ Hits 11535 12682 +1147
+ Misses 5143 3991 -1152
+ Partials 26 23 -3 ☔ View full report in Codecov by Sentry. |
Yohe-Am
requested review from
a team,
michael-0acf4 and
zifeo
and removed request for
zifeo
Contributor
Author
|
Note, I've updated this to a release candidate version just to make sure the changes to the release pipeline are good before anything. |
zifeo
reviewed
Sep 1, 2024
Member
zifeo
left a comment
zifeo
left a comment
There was a problem hiding this comment.
LGTM, Massive!
There are 2 files left under website, likely due to a clashing merge:
michael-0acf4
previously approved these changes
Sep 1, 2024
michael-0acf4
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libs/tosrc/.typegate/,meta-cli,typegraph/,meta-lsp/tosrc/.dev/totools/website/todocs/metatype.dev/src/typegate/teststotests/src/typegraph/deno/devtotools/jsr/src/typegraph/deno/sdktosrc/typegraph/deno/src/denotosrc/mt_deno1.46.11.80.1tools/task-*.tstotools/task/*.tscliff.toml,Cross.toml,ruff.tomltotools/src/typegraph/deno,src/typegate,tools/,tests/and more.Migration notes
No end user changes required
The change comes with new or modified tests
Hard-to-understand functions have explanatory comments
End-user documentation is updated to reflect the change